Bug 80368 - pinch-to-zoom and double-tap flicker when using the new scrolling model
Summary: pinch-to-zoom and double-tap flicker when using the new scrolling model
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 19:45 PST by Anders Carlsson
Modified: 2012-03-05 20:35 PST (History)
0 users

See Also:


Attachments
Patch (13.66 KB, patch)
2012-03-05 19:55 PST, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (14.06 KB, patch)
2012-03-05 20:23 PST, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-03-05 19:45:40 PST
pinch-to-zoom and double-tap flicker when using the new scrolling model
Comment 1 Anders Carlsson 2012-03-05 19:55:39 PST
Created attachment 130271 [details]
Patch
Comment 2 Build Bot 2012-03-05 20:17:33 PST
Comment on attachment 130271 [details]
Patch

Attachment 130271 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11834148
Comment 3 Anders Carlsson 2012-03-05 20:23:03 PST
Created attachment 130275 [details]
Patch
Comment 4 Sam Weinig 2012-03-05 20:28:40 PST
Comment on attachment 130275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130275&action=review

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:141
> +static void dispatchBackToMainThread(uint64_t webPageID, uint64_t callbackID)

Please consider renaming this to dispatchForceRepaintBackToMainThread or something like that.  Or just add a fixme about adding barriers/fences.
Comment 5 Anders Carlsson 2012-03-05 20:33:58 PST
Committed r109843: <http://trac.webkit.org/changeset/109843>
Comment 6 mitz 2012-03-05 20:35:12 PST
Comment on attachment 130275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130275&action=review

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:95
> +    IntRect scaledRect = rect;
> +    scaledRect.scale(m_scale);

IntRect::scale() truncates the origin and the size. I think this can cause problems.