RESOLVED FIXED80367
[BlackBerry]New feature: support about:cookie for internal build. 
https://bugs.webkit.org/show_bug.cgi?id=80367
Summary [BlackBerry]New feature: support about:cookie for internal build.
Jason Liu
Reported 2012-03-05 19:30:07 PST
Need to show detail information of cookies.
Attachments
Patch (5.48 KB, patch)
2012-03-05 22:06 PST, Jason Liu 		no flags
DetailsFormatted DiffDiff
Patch (5.35 KB, patch)
2012-03-06 17:50 PST, Jason Liu 		no flags
DetailsFormatted DiffDiff
Patch (5.25 KB, patch)
2012-03-07 22:51 PST, Jason Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jason Liu
Comment 1 2012-03-05 22:06:44 PST
Created attachment 130286 [details] Patch
Joe Mason
Comment 2 2012-03-06 08:08:47 PST
Comment on attachment 130286 [details] Patch There's no reason to declare cookieMap outside the for loop, since it's not used again. You also shouldn't call getAllCookies as well as getAllChildCookies, since getAllChildCookies calls getAllCookies already, so this goes through the top-level map twice.
Jason Liu
Comment 3 2012-03-06 17:50:36 PST
Created attachment 130499 [details] Patch
Charles Wei
Comment 4 2012-03-07 19:38:10 PST
Comment on attachment 130499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130499&action=review > Source/WebCore/platform/blackberry/CookieManager.cpp:231 > + result.append(String("<table style=\"word-wrap:break-word\" cellSpacing=\"0\" cellPadding=\"0\" border=\"1\"><tr><th width=\"54\">Domain</th><th width=\"32\">Path</th><th width=\"57\">Protocol</th><th width=\"40\">Name</th><th width=\"40\">Value</th><th width=\"46\">Secure</th><th width=\"64\">HttpOnly</th><th width=\"49\">Session</th></tr>")); I don't link all the hardcoded numbers. Any other way to make it more intuitive ?
Jason Liu
Comment 5 2012-03-07 22:51:52 PST
Created attachment 130774 [details] Patch
Joe Mason
Comment 6 2012-03-08 08:25:10 PST
LGTM
WebKit Review Bot
Comment 7 2012-03-08 11:01:58 PST
Comment on attachment 130774 [details] Patch Clearing flags on attachment: 130774 Committed r110176: <http://trac.webkit.org/changeset/110176>
WebKit Review Bot
Comment 8 2012-03-08 11:02:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.