Bug 80367 - [BlackBerry]New feature: support about:cookie for internal build.
Summary: [BlackBerry]New feature: support about:cookie for internal build.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-03-05 19:30 PST by Jason Liu
Modified: 2012-03-08 11:02 PST (History)
8 users (show)

See Also:

Patch (5.48 KB, patch)
2012-03-05 22:06 PST, Jason Liu
no flags Details | Formatted Diff | Diff
Patch (5.35 KB, patch)
2012-03-06 17:50 PST, Jason Liu
no flags Details | Formatted Diff | Diff
Patch (5.25 KB, patch)
2012-03-07 22:51 PST, Jason Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Liu 2012-03-05 19:30:07 PST
Need to show detail information of cookies.
Comment 1 Jason Liu 2012-03-05 22:06:44 PST
Created attachment 130286 [details]
Comment 2 Joe Mason 2012-03-06 08:08:47 PST
Comment on attachment 130286 [details]

There's no reason to declare cookieMap outside the for loop, since it's not used again.
You also shouldn't call getAllCookies as well as getAllChildCookies, since getAllChildCookies calls getAllCookies already, so this goes through the top-level map twice.
Comment 3 Jason Liu 2012-03-06 17:50:36 PST
Created attachment 130499 [details]
Comment 4 Charles Wei 2012-03-07 19:38:10 PST
Comment on attachment 130499 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=130499&action=review

> Source/WebCore/platform/blackberry/CookieManager.cpp:231
> +    result.append(String("<table style=\"word-wrap:break-word\" cellSpacing=\"0\" cellPadding=\"0\" border=\"1\"><tr><th width=\"54\">Domain</th><th width=\"32\">Path</th><th width=\"57\">Protocol</th><th width=\"40\">Name</th><th width=\"40\">Value</th><th width=\"46\">Secure</th><th width=\"64\">HttpOnly</th><th width=\"49\">Session</th></tr>"));

I don't link all the hardcoded numbers. Any other way to make it more intuitive ?
Comment 5 Jason Liu 2012-03-07 22:51:52 PST
Created attachment 130774 [details]
Comment 6 Joe Mason 2012-03-08 08:25:10 PST
Comment 7 WebKit Review Bot 2012-03-08 11:01:58 PST
Comment on attachment 130774 [details]

Clearing flags on attachment: 130774

Committed r110176: <http://trac.webkit.org/changeset/110176>
Comment 8 WebKit Review Bot 2012-03-08 11:02:02 PST
All reviewed patches have been landed.  Closing bug.