Bug 80361 - DFG BasicBlock should group the Phi nodes together and separate them from the other nodes
Summary: DFG BasicBlock should group the Phi nodes together and separate them from the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 80415
  Show dependency tree / graph
 
Reported: 2012-03-05 17:45 PST by Yuqiang Xian
Modified: 2012-03-06 20:57 PST (History)
2 users (show)

See Also:

Attachments
patch (12.46 KB, patch)
2012-03-05 18:00 PST, Yuqiang Xian 		fpizlo: review+
Details | Formatted Diff | Diff
Performance result (6.95 KB, text/plain)
2012-03-05 18:01 PST, Yuqiang Xian 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuqiang Xian 2012-03-05 17:45:03 PST 
This would make it more efficient to remove the redundant Phi nodes or insert new Phi nodes for SSA, besides providing a cleaner BasicBlock structure.
Comment 1 Yuqiang Xian 2012-03-05 18:00:23 PST 
Created attachment 130254 [details]
patch
Comment 2 Yuqiang Xian 2012-03-05 18:01:13 PST 
Created attachment 130255 [details]
Performance result

This is performance neutral. See attached.
Comment 3 Filip Pizlo 2012-03-06 19:14:38 PST 
Comment on attachment 130254 [details]
patch

I like this a lot!  R=me.
Comment 4 Yuqiang Xian 2012-03-06 20:57:02 PST 
Landed as http://trac.webkit.org/changeset/110008