Bug 80352 - WorkerContext shouldn't need to know about SQLDatabase
Summary: WorkerContext shouldn't need to know about SQLDatabase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
: 79473 (view as bug list)
Depends on:
Blocks: 79327
  Show dependency tree / graph
 
Reported: 2012-03-05 16:56 PST by Adam Barth
Modified: 2012-03-06 00:03 PST (History)
7 users (show)

See Also:

Attachments
Patch (24.01 KB, patch)
2012-03-05 16:59 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-03-05 16:56:08 PST 
WorkerContext shouldn't need to know about SQLDatabase
Comment 1 Adam Barth 2012-03-05 16:59:02 PST 
Created attachment 130235 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-03-05 17:03:03 PST 
Comment on attachment 130235 [details]
Patch

OK.
Comment 3 Kentaro Hara 2012-03-05 17:04:34 PST 
*** Bug 79473 has been marked as a duplicate of this bug. ***
Comment 4 WebKit Review Bot 2012-03-05 18:30:46 PST 
Comment on attachment 130235 [details]
Patch

Clearing flags on attachment: 130235

Committed r109833: <http://trac.webkit.org/changeset/109833>
Comment 5 WebKit Review Bot 2012-03-05 18:30:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Philippe Normand 2012-03-05 23:39:18 PST 
This change caused the fast/workers/storage tests to fail on GTK (at least).
Some tests show this message on the console: Can't find variable: openDatabaseSync
Comment 7 Adam Barth 2012-03-05 23:42:26 PST 
I think I fixed that already in http://trac.webkit.org/changeset/109861 .  Are they still failing?
Comment 8 Philippe Normand 2012-03-05 23:47:19 PST 
(In reply to comment #7)
> I think I fixed that already in http://trac.webkit.org/changeset/109861 .  Are they still failing?

Yes, http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release?numbuilds=50
Since r109833.
Comment 9 Philippe Normand 2012-03-06 00:03:27 PST 
(In reply to comment #8)
> (In reply to comment #7)
> > I think I fixed that already in http://trac.webkit.org/changeset/109861 .  Are they still failing?
> 
> Yes, http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release?numbuilds=50
> Since r109833.

A clean build is the solution. False alarm and sorry for the noise Adam!