Once again, WebCore is failing to build Release on Windows.
Created attachment 130230 [details] AllInOne files for several projects
Attachment 130230 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/loader/appcache/ApplicationCacheAllInOne.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/platform/text/TextAllInOne.cpp:39: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 130274 [details] Updated to fix style check For some reason, the ApplicationCacheAllInOne.cpp fails style check. The error message is not helpful. check-webkit-style Source/WebCore/loader/appcache/ApplicationCacheAllInOne.cpp Source/WebCore/loader/appcache/ApplicationCacheAllInOne.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 1 files
Attachment 130274 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/loader/appcache/ApplicationCacheAllInOne.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #4) > Attachment 130274 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > Source/WebCore/loader/appcache/ApplicationCacheAllInOne.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] > Total errors found: 1 in 6 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. This is a false positive, and there is already a bug about it: check-webkit-style false error on build/include_order for .cpp files with no .h https://bugs.webkit.org/show_bug.cgi?id=43881
Comment on attachment 130274 [details] Updated to fix style check View in context: https://bugs.webkit.org/attachment.cgi?id=130274&action=review It would probably be good to go through all the existing AllInOne.cpp files and make sure that new files that have been added in those areas have also been added to those AllInOne.cpp files. But that can be done in a separate patch. > Source/WebCore/css/MediaAllInOne.cpp:28 > + Nit pick: Extra line here.
Comment on attachment 130274 [details] Updated to fix style check Because my only issue was an extra-line nit-pick, I think it is ok to have the commit-queue just land the patch as-is.
Comment on attachment 130274 [details] Updated to fix style check Rejecting attachment 130274 [details] from review queue. jberlin@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Comment on attachment 130274 [details] Updated to fix style check Fixed in http://trac.webkit.org/changeset/109929