Bug 80344 - GCActivityCallback timer should vary with the length of the previous GC
Summary: GCActivityCallback timer should vary with the length of the previous GC
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
Depends on:
Reported: 2012-03-05 16:29 PST by Mark Hahnenberg
Modified: 2012-03-06 13:32 PST (History)
1 user (show)

See Also:

Patch (4.11 KB, patch)
2012-03-05 19:20 PST, Mark Hahnenberg
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-03-05 16:29:15 PST
Currently our GC callback timer has a fixed length of 2 seconds. We should change it to be vary based on the length of the previous GC. This will allow us to control at a more fine-grained level exactly how much garbage collection should/is going on at a particular time.
Comment 1 Mark Hahnenberg 2012-03-05 19:20:41 PST
Created attachment 130267 [details]
Comment 2 Geoffrey Garen 2012-03-06 09:44:33 PST
Comment on attachment 130267 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=130267&action=review


> Source/JavaScriptCore/heap/Heap.cpp:332
> +    , m_lastGCStartTime(0)
> +    , m_lastGCEndTime(0)

These two should just be local variables inside collect().
Comment 3 Mark Hahnenberg 2012-03-06 13:32:38 PST
Committed r109956: <http://trac.webkit.org/changeset/109956>