RESOLVED FIXED 80341
flakiness dashboard doesn't display baselines for virtual tests correctly 
https://bugs.webkit.org/show_bug.cgi?id=80341
Summary flakiness dashboard doesn't display baselines for virtual tests correctly
Dirk Pranke
Reported 2012-03-05 15:50:20 PST
flakiness dashboard doesn't display baselines for virtual tests correctly
Attachments
Patch (10.07 KB, patch)
2012-03-05 15:52 PST, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-03-05 15:52:18 PST
Created attachment 130216 [details] Patch
Ojan Vafai
Comment 2 2012-03-05 16:00:01 PST
Comment on attachment 130216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130216&action=review > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2205 > + addExpectationItem(expectationsContainers, expectationsContainer, null, test, TEST_URL_BASE_PATH); May as well put an "if (!suite)" before this since this will always 404 if it is a virtual test, right? > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2219 > + if (suite) { > + loadBaselinesForTest(expectationsContainers, expectationsContainer, baseTest(test, suite)); > + } Nit: WebKit style is to not put the curly braces.
Dirk Pranke
Comment 3 2012-03-05 16:08:06 PST
(In reply to comment #2) > (From update of attachment 130216 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130216&action=review > > > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2205 > > + addExpectationItem(expectationsContainers, expectationsContainer, null, test, TEST_URL_BASE_PATH); > > May as well put an "if (!suite)" before this since this will always 404 if it is a virtual test, right? > True. Will add. > > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2219 > > + if (suite) { > > + loadBaselinesForTest(expectationsContainers, expectationsContainer, baseTest(test, suite)); > > + } > > Nit: WebKit style is to not put the curly braces. Ok.
Dirk Pranke
Comment 4 2012-03-05 16:11:43 PST
Committed r109810: <http://trac.webkit.org/changeset/109810>
Note You need to log in before you can comment on or make changes to this bug.