Bug 80341 - flakiness dashboard doesn't display baselines for virtual tests correctly
Summary: flakiness dashboard doesn't display baselines for virtual tests correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 15:50 PST by Dirk Pranke
Modified: 2012-03-05 16:11 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.07 KB, patch)
2012-03-05 15:52 PST, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-03-05 15:50:20 PST 
flakiness dashboard doesn't display baselines for virtual tests correctly
Comment 1 Dirk Pranke 2012-03-05 15:52:18 PST 
Created attachment 130216 [details]
Patch
Comment 2 Ojan Vafai 2012-03-05 16:00:01 PST 
Comment on attachment 130216 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130216&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2205
> +    addExpectationItem(expectationsContainers, expectationsContainer, null, test, TEST_URL_BASE_PATH);

May as well put an "if (!suite)" before this since this will always 404 if it is a virtual test, right?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2219
> +    if (suite) {
> +        loadBaselinesForTest(expectationsContainers, expectationsContainer, baseTest(test, suite));
> +    }

Nit: WebKit style is to not put the curly braces.
Comment 3 Dirk Pranke 2012-03-05 16:08:06 PST 
(In reply to comment #2)
> (From update of attachment 130216 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130216&action=review
> 
> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2205
> > +    addExpectationItem(expectationsContainers, expectationsContainer, null, test, TEST_URL_BASE_PATH);
> 
> May as well put an "if (!suite)" before this since this will always 404 if it is a virtual test, right?
> 

True. Will add.

> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2219
> > +    if (suite) {
> > +        loadBaselinesForTest(expectationsContainers, expectationsContainer, baseTest(test, suite));
> > +    }
> 
> Nit: WebKit style is to not put the curly braces.

Ok.
Comment 4 Dirk Pranke 2012-03-05 16:11:43 PST 
Committed r109810: <http://trac.webkit.org/changeset/109810>