Bug 80335 - putByIndex should throw in strict mode
: putByIndex should throw in strict mode
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Gavin Barraclough
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-05 15:13 PST by Gavin Barraclough
Modified: 2012-03-06 23:49 PST (History)
5 users (show)

See Also:


Attachments
patch (16.89 KB, patch)
2012-03-05 16:28 PST, Gavin Barraclough
fpizlo: review+
Details | Formatted Diff | Diff
Part 2 - fixes pretty much everything. (72.90 KB, patch)
2012-03-05 22:45 PST, Gavin Barraclough
fpizlo: review+
buildbot: commit‑queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-03-05 15:13:36 PST
We'll need to pass an additional parameter.
Comment 1 Gavin Barraclough 2012-03-05 16:28:28 PST
Created attachment 130226 [details]
patch
Comment 2 Gavin Barraclough 2012-03-05 17:20:25 PST
Fixed for primitives in r109824.
Comment 3 Gavin Barraclough 2012-03-05 22:45:50 PST
Created attachment 130298 [details]
Part 2 - fixes pretty much everything.
Comment 4 Gavin Barraclough 2012-03-05 23:24:00 PST
Part 2 landed in r109866, still need some fixing for shift/unshift.
Comment 5 Build Bot 2012-03-05 23:24:29 PST
Comment on attachment 130298 [details]
Part 2 - fixes pretty much everything.

Attachment 130298 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11837199
Comment 6 WebKit Review Bot 2012-03-05 23:26:07 PST
Comment on attachment 130298 [details]
Part 2 - fixes pretty much everything.

Attachment 130298 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11836194

New failing tests:
fast/js/mozilla/strict/15.4.4.13.html
fast/js/mozilla/strict/15.4.4.8.html
fast/js/mozilla/strict/15.4.4.9.html
fast/js/mozilla/strict/15.4.4.12.html
Comment 7 Kentaro Hara 2012-03-06 01:50:34 PST
(In reply to comment #6)
> (From update of attachment 130298 [details])
> Attachment 130298 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11836194
> 
> New failing tests:
> fast/js/mozilla/strict/15.4.4.13.html
> fast/js/mozilla/strict/15.4.4.8.html
> fast/js/mozilla/strict/15.4.4.9.html
> fast/js/mozilla/strict/15.4.4.12.html

It seems that this needs a V8 fix. I marked these tests as TEXT, and filed a bug in V8: http://code.google.com/p/v8/issues/detail?id=1992
Comment 8 Gavin Barraclough 2012-03-06 23:49:43 PST
Last piece of this was resolved as a part of bug#80467