The WKWebInspectorProxyObjCAdapter class impelments actions that are used by the Develop menu. This is hard to support and makes changing the Develop menu difficult. We shoudl expose WKWebInspectorProxyObjCAdapter so Safari can add the methods it needs.
Created attachment 130172 [details] Proposed Change
Attachment 130172 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/C/mac/WKInspectorPrivateMac.h:26: #ifndef header guard has wrong style, please use: WKInspectorPrivateMac_h [build/header_guard] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 130172 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 > Source/WebKit2/UIProcess/API/C/mac/WKInspectorPrivateMac.h:26: #ifndef header guard has wrong style, please use: WKInspectorPrivateMac_h [build/header_guard] [5] > Total errors found: 1 in 4 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Fixed locally.
Created attachment 130192 [details] Proposed Change (round 2) With header guard fixed and inspectorRef as a @property.
Attachment 130192 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/C/mac/WKInspectorPrivateMac.h:38: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
r109795