RESOLVED FIXED80306
Web Inspector: [Regression] Execution line is not revealed when debugger is stopped if scripts panel was not yet shown. 
https://bugs.webkit.org/show_bug.cgi?id=80306
Summary Web Inspector: [Regression] Execution line is not revealed when debugger is s...
Vsevolod Vlasov
Reported 2012-03-05 11:25:20 PST
Execution line is not revealed when debugger is stopped if scripts panel was not yet shown.
Attachments
Patch (11.72 KB, patch)
2012-03-05 12:12 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (12.65 KB, patch)
2012-03-06 04:05 PST, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-03-05 12:12:56 PST
Created attachment 130177 [details] Patch
WebKit Review Bot
Comment 2 2012-03-05 13:53:12 PST
Comment on attachment 130177 [details] Patch Attachment 130177 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11818174 New failing tests: inspector/debugger/callstack-placards-discarded.html
Pavel Feldman
Comment 3 2012-03-05 22:04:10 PST
@podivilov: could you take a look?
Pavel Podivilov
Comment 4 2012-03-05 23:37:41 PST
Comment on attachment 130177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130177&action=review Looks good! > Source/WebCore/inspector/front-end/SourceFrame.js:216 > + if (this._lineToReveal) _lineToReveal is zero based, please fix the condition or delete unconditionally.
Vsevolod Vlasov
Comment 5 2012-03-06 04:05:33 PST
Created attachment 130350 [details] Patch
Vsevolod Vlasov
Comment 6 2012-03-06 04:29:15 PST
Committed r109903: <http://trac.webkit.org/changeset/109903>
Note You need to log in before you can comment on or make changes to this bug.