Bug 80306 - Web Inspector: [Regression] Execution line is not revealed when debugger is stopped if scripts panel was not yet shown.
Summary: Web Inspector: [Regression] Execution line is not revealed when debugger is s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 11:25 PST by Vsevolod Vlasov
Modified: 2012-03-06 04:29 PST (History)
13 users (show)

See Also:

Attachments
Patch (11.72 KB, patch)
2012-03-05 12:12 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (12.65 KB, patch)
2012-03-06 04:05 PST, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-03-05 11:25:20 PST 
Execution line is not revealed when debugger is stopped if scripts panel was not yet shown.
Comment 1 Vsevolod Vlasov 2012-03-05 12:12:56 PST 
Created attachment 130177 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-05 13:53:12 PST 
Comment on attachment 130177 [details]
Patch

Attachment 130177 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11818174

New failing tests:
inspector/debugger/callstack-placards-discarded.html
Comment 3 Pavel Feldman 2012-03-05 22:04:10 PST 
@podivilov: could you take a look?
Comment 4 Pavel Podivilov 2012-03-05 23:37:41 PST 
Comment on attachment 130177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130177&action=review

Looks good!

> Source/WebCore/inspector/front-end/SourceFrame.js:216
> +        if (this._lineToReveal)

_lineToReveal is zero based, please fix the condition or delete unconditionally.
Comment 5 Vsevolod Vlasov 2012-03-06 04:05:33 PST 
Created attachment 130350 [details]
Patch
Comment 6 Vsevolod Vlasov 2012-03-06 04:29:15 PST 
Committed r109903: <http://trac.webkit.org/changeset/109903>