Bug 80304 - Web Inspector: move timeline panel overview mode toggle buttons to overview sidebar tree
Summary: Web Inspector: move timeline panel overview mode toggle buttons to overview s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 11:11 PST by Andrey Kosyakov
Modified: 2012-03-06 04:09 PST (History)
10 users (show)

See Also:


Attachments
Patch (34.80 KB, patch)
2012-03-05 11:15 PST, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff
screenshot (22.03 KB, image/png)
2012-03-05 11:19 PST, Andrey Kosyakov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-03-05 11:11:53 PST
This renames experimental "start-at-zero" mode to "vertical overview" mode and replaces a status-bar button with two buttons next to "Timelines" item in the timeline overview sidebar.
Comment 1 Andrey Kosyakov 2012-03-05 11:15:03 PST
Created attachment 130162 [details]
Patch
Comment 2 Andrey Kosyakov 2012-03-05 11:19:51 PST
Created attachment 130164 [details]
screenshot
Comment 3 Pavel Feldman 2012-03-05 22:03:20 PST
Comment on attachment 130162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130162&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:51
> +        this._overviewModeSelector.addButton(WebInspector.UIString("Show each event category as a horizontal strip in overview"),

Do not forget to update localizedStrings

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:157
> +        if (!enabled === !this._verticalOverview)

if (enabled === this._verticalOverview) ?

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:173
> +        if (this._currentMode === WebInspector.TimelineOverviewPane.Mode.Memory)

This looks ugly and the reason seems to be that you mix Horizontal / Vertical modes with the Memory one.

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:964
> +WebInspector.TimelineVerticalOverview.prototype.__proto__ = WebInspector.View.prototype;

Do we need a 60 line class for a toggle button?

> Source/WebCore/inspector/front-end/TimelinePanel.js:386
> +            this._repopulateRecords();

I don't think panel should be initiating repopulate. It sounds like overview should call tell the presentation model to repopulate instead.

> Source/WebCore/inspector/front-end/timelinePanel.css:672
> +    background-image: -webkit-linear-gradient(top, rgb(80, 80, 80), rgb(140, 140, 140) 3px, rgb(160, 160, 160));

Gradients and text shadow look ugly on the screenshot. Could you remove those?
Comment 4 Andrey Kosyakov 2012-03-06 04:09:43 PST
Committed r109898: <http://trac.webkit.org/changeset/109898>