Bug 80290 - [chromium] Remove old cleanupResources() code
Summary: [chromium] Remove old cleanupResources() code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 08:06 PST by Dana Jansens
Modified: 2012-03-05 12:06 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.46 KB, patch)
2012-03-05 08:08 PST, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-03-05 08:06:11 PST
[chromium] Remove old cleanupResources() code
Comment 1 Dana Jansens 2012-03-05 08:08:39 PST
Created attachment 130139 [details]
Patch
Comment 2 Dana Jansens 2012-03-05 08:18:24 PST
cleanupResources() is called from destructors, primarily to call cleanupResources on the layer's RenderSurface. That surface is held by an OwnPtr, so its destructor will be called anyways. And RS::cleanupResources is used to clear OwnPtrs within the surface.

Basically, this function is redundant with destructors now, though I imagine it served some larger purpose in the past, which has been solved with OwnPtrs now.
Comment 3 Adrienne Walker 2012-03-05 10:48:16 PST
Comment on attachment 130139 [details]
Patch

Nice cleanup! :)
Comment 4 WebKit Review Bot 2012-03-05 12:05:59 PST
Comment on attachment 130139 [details]
Patch

Clearing flags on attachment: 130139

Committed r109781: <http://trac.webkit.org/changeset/109781>
Comment 5 WebKit Review Bot 2012-03-05 12:06:03 PST
All reviewed patches have been landed.  Closing bug.