Bug 80286 - Web Inspector: stop using RawSourceCode in BreakpointManager.
Summary: Web Inspector: stop using RawSourceCode in BreakpointManager.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 07:59 PST by Pavel Podivilov
Modified: 2012-03-06 00:11 PST (History)
10 users (show)

See Also:


Attachments
Patch (14.51 KB, patch)
2012-03-05 08:02 PST, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch (21.15 KB, patch)
2012-03-05 09:32 PST, Pavel Podivilov
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-03-05 07:59:24 PST
Web Inspector: stop using RawSourceCode in BreakpointManager.

See bug 79130 for why it's needed.
Comment 1 Pavel Podivilov 2012-03-05 08:02:53 PST
Created attachment 130135 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-05 08:59:06 PST
Comment on attachment 130135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130135&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:37
> + * @param {WebInspector.DebuggerPresentationModel} sourceMapping

Maybe scriptMapping?
Could you please add an interface (ScriptMapping?) and implement it in DebuggerPresentationModel?

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:45
> +    this._breakpointManager = new WebInspector.BreakpointManager(WebInspector.settings.breakpoints,

I think one long line would be better.
Comment 3 Pavel Podivilov 2012-03-05 09:32:06 PST
Created attachment 130153 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-03-05 09:36:38 PST
Comment on attachment 130153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130153&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:45
> +    this._breakpointManager = new WebInspector.BreakpointManager(WebInspector.settings.breakpoints,

One line?

> Source/WebCore/inspector/front-end/ScriptMapping.js:48
> +    rawLocationToUILocation: function(rawLocation)

rawLocationToUILocation: function(rawLocation) { },

> Source/WebCore/inspector/front-end/ScriptMapping.js:58
> +    uiLocationToRawLocation: function(uiSourceCode, lineNumber, columnNumber)

ditto

> Source/WebCore/inspector/front-end/ScriptMapping.js:68
> +    {

ditto

> Source/WebCore/inspector/front-end/ScriptMapping.js:75
> +    {

ditto
Comment 5 Pavel Podivilov 2012-03-06 00:11:46 PST
Committed r109872: <http://trac.webkit.org/changeset/109872>