RESOLVED FIXED80286
Web Inspector: stop using RawSourceCode in BreakpointManager. 
https://bugs.webkit.org/show_bug.cgi?id=80286
Summary Web Inspector: stop using RawSourceCode in BreakpointManager.
Pavel Podivilov
Reported 2012-03-05 07:59:24 PST
Web Inspector: stop using RawSourceCode in BreakpointManager. See bug 79130 for why it's needed.
Attachments
Patch (14.51 KB, patch)
2012-03-05 08:02 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (21.15 KB, patch)
2012-03-05 09:32 PST, Pavel Podivilov 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2012-03-05 08:02:53 PST
Created attachment 130135 [details] Patch
Vsevolod Vlasov
Comment 2 2012-03-05 08:59:06 PST
Comment on attachment 130135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130135&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:37 > + * @param {WebInspector.DebuggerPresentationModel} sourceMapping Maybe scriptMapping? Could you please add an interface (ScriptMapping?) and implement it in DebuggerPresentationModel? > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:45 > + this._breakpointManager = new WebInspector.BreakpointManager(WebInspector.settings.breakpoints, I think one long line would be better.
Pavel Podivilov
Comment 3 2012-03-05 09:32:06 PST
Created attachment 130153 [details] Patch
Vsevolod Vlasov
Comment 4 2012-03-05 09:36:38 PST
Comment on attachment 130153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130153&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:45 > + this._breakpointManager = new WebInspector.BreakpointManager(WebInspector.settings.breakpoints, One line? > Source/WebCore/inspector/front-end/ScriptMapping.js:48 > + rawLocationToUILocation: function(rawLocation) rawLocationToUILocation: function(rawLocation) { }, > Source/WebCore/inspector/front-end/ScriptMapping.js:58 > + uiLocationToRawLocation: function(uiSourceCode, lineNumber, columnNumber) ditto > Source/WebCore/inspector/front-end/ScriptMapping.js:68 > + { ditto > Source/WebCore/inspector/front-end/ScriptMapping.js:75 > + { ditto
Pavel Podivilov
Comment 5 2012-03-06 00:11:46 PST
Committed r109872: <http://trac.webkit.org/changeset/109872>
Note You need to log in before you can comment on or make changes to this bug.