Bug 80277 - [Qt] Create EWS to build WebKit2
Summary: [Qt] Create EWS to build WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 06:16 PST by Kristóf Kosztyó
Modified: 2012-03-06 01:23 PST (History)
5 users (show)

See Also:

Attachments
create wk2 ews (2.32 KB, patch)
2012-03-05 06:25 PST, Kristóf Kosztyó 		ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff
fix the naming issues (2.31 KB, patch)
2012-03-06 00:42 PST, Kristóf Kosztyó 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kristóf Kosztyó 2012-03-05 06:16:40 PST 
It would be very useful if the ews system also built webkit2.
Comment 1 Kristóf Kosztyó 2012-03-05 06:25:27 PST 
Created attachment 130113 [details]
create wk2 ews
Comment 2 Csaba Osztrogonác 2012-03-05 06:54:56 PST 
Comment on attachment 130113 [details]
create wk2 ews

View in context: https://bugs.webkit.org/attachment.cgi?id=130113&action=review

LGTM, r=me with the following changes.

> Tools/ChangeLog:3
> +        [Qt] Create ews to build webkit2

ews -> EWS
webkit2 -> WebKit2

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:163
> +class QtWk2EWS(AbstractEarlyWarningSystem):

QtWk2EWS -> QtWK2EWS

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:86
> +        self._test_builder_ews(QtWk2EWS())

QtWk2EWS -> QtWK2EWS
Comment 3 Csaba Osztrogonác 2012-03-05 06:56:07 PST 
Eric, Adam, will http://queues.webkit.org/ be updated automatically after this patch lands?
Comment 4 Adam Barth 2012-03-05 10:06:18 PST 
> Eric, Adam, will http://queues.webkit.org/ be updated automatically after this patch lands?

Nope.  We'll need to do a re-deploy manually.  Ping Eric or me when it lands and we can do that easily for you.
Comment 5 Kristóf Kosztyó 2012-03-06 00:42:15 PST 
Created attachment 130320 [details]
fix the naming issues
Comment 6 WebKit Review Bot 2012-03-06 01:23:32 PST 
Comment on attachment 130320 [details]
fix the naming issues

Clearing flags on attachment: 130320

Committed r109878: <http://trac.webkit.org/changeset/109878>
Comment 7 WebKit Review Bot 2012-03-06 01:23:37 PST 
All reviewed patches have been landed.  Closing bug.