Bug 80275 - Web Inspector: [Regression] Message bubbles are not removed from scripts panel source frames after console was cleared.
Summary: Web Inspector: [Regression] Message bubbles are not removed from scripts pane...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 06:06 PST by Vsevolod Vlasov
Modified: 2012-03-06 01:33 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.46 KB, patch)
2012-03-05 06:08 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (5.82 KB, patch)
2012-03-05 07:50 PST, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Screenshot (safari mac) (40.07 KB, image/png)
2012-03-05 08:09 PST, Vsevolod Vlasov 		no flags Details
Screenshot (chromium linux) (70.62 KB, image/png)
2012-03-05 08:14 PST, Vsevolod Vlasov 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-03-05 06:06:00 PST 
Message bubbles are not removed from scripts panel source frames after console was cleared.
Comment 1 Vsevolod Vlasov 2012-03-05 06:08:23 PST 
Created attachment 130108 [details]
Patch
Comment 2 Pavel Feldman 2012-03-05 06:19:55 PST 
Comment on attachment 130108 [details]
Patch

Could we have a test for this?
Comment 3 Vsevolod Vlasov 2012-03-05 07:50:50 PST 
Created attachment 130133 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-03-05 08:09:50 PST 
Created attachment 130140 [details]
Screenshot (safari mac)
Comment 5 Vsevolod Vlasov 2012-03-05 08:14:45 PST 
Created attachment 130142 [details]
Screenshot (chromium linux)
Comment 6 Pavel Feldman 2012-03-05 21:41:59 PST 
Re: screenshot: wrong bug?
Comment 7 Pavel Feldman 2012-03-05 21:49:55 PST 
Comment on attachment 130133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130133&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:297
> +        var sourceFrames = this._sourceFramesByUISourceCode.values();

This sounds more like compilation error rather than semantics error. Can we annotate the map interaction so that the compiler could catch such errors?
Comment 8 Vsevolod Vlasov 2012-03-06 01:33:37 PST 
Committed r109882: <http://trac.webkit.org/changeset/109882>