Bug 80272 - [Qt] Unify layout test results across Linux and Mac
Summary: [Qt] Unify layout test results across Linux and Mac
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords: Qt, QtTriaged
Depends on: 80996
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-05 05:47 PST by Balazs Kelemen
Modified: 2012-09-25 05:57 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-03-05 05:47:50 PST
The goal is to enable redertree tests on Mac without the need to duplicate expected results.
There are a few steps witch should be and seems to be sufficient for that:
1. Add a test-only font database for Mac to be able to use the test fonts there. It is tracked in http://codereview.qt-project.org/#change,18426
2. Add a way to force using design metrics for DRT/WTR. I'm going to upload it here.
3. Convert test fonts to ttf, adjust expected results for the change. The conversion is necessary because Mac does not like the postscript font file format (.pfb). Unfortunately the conversation cause some changes (I did it with fontforge).
4. Some way workaround a bug in Debian/Ubuntu that makes the Ahem font not matching with other freetype based environments (both Linux and Mac). They report +1 for height which is quite weird according to the fact that Ahem is a font type for only testing purposes that have 1/1 width/height ratio by definition.
5. Finale: commit new expected results, remove tests from Mac skiplist, make the bots use the test font database.

In the future we can also fix this for Windows.
Comment 1 Balazs Kelemen 2012-03-06 09:25:38 PST
Seems like the Ahem font bug is not that evil as I thought. It's only an issue with freetype versions less than 2.5. This means that it would be fixed in the next Ubuntu release. I would like to switch to the correct baselines ASAP and make the bots use a fresh freetype. We can also add a warning to the build / tools to inform developers if they have too old version. We can also add a dependency to Gabor's PPA if that's possible.
Comment 2 Balazs Kelemen 2012-03-13 08:52:51 PDT
I'm planning to achieve the first step with an external platform plugin which we can add to WebKit (under Tools of course).
Comment 3 Csaba Osztrogonác 2012-04-17 05:42:50 PDT
Is there any progression?
Comment 4 Balazs Kelemen 2012-04-17 06:20:31 PDT
(In reply to comment #3)
> Is there any progression?

There is ;) I have uploaded an updated patch for the platform plugin yesterday (#80996).
Comment 5 Balazs Kelemen 2012-09-25 05:57:12 PDT
Unfortunately the patch in bug 80996 does not produce good results so this way of unifying will most likely not work.