RESOLVED FIXED 80268
Web Inspector: check for the number of parsed css properties. 
https://bugs.webkit.org/show_bug.cgi?id=80268
Summary Web Inspector: check for the number of parsed css properties.
Pavel Feldman
Reported 2012-03-05 05:20:00 PST
Not tests yet since can't repro.
Attachments
Patch (2.29 KB, patch)
2012-03-05 05:21 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (5.61 KB, patch)
2012-03-05 06:35 PST, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-03-05 05:21:19 PST
Created attachment 130098 [details] Patch
Pavel Feldman
Comment 2 2012-03-05 06:35:45 PST
Created attachment 130114 [details] Patch
Vsevolod Vlasov
Comment 3 2012-03-05 06:52:02 PST
Comment on attachment 130114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130114&action=review > LayoutTests/inspector/styles/set-property-boundaries.html:27 > + for (var i = 0; i < infos.length; ++i) Could you please use the first item only instead of iterating over all the items? > LayoutTests/inspector/styles/set-property-boundaries.html:39 > + for (var i = 0; i < styleSheet.rules.length; ++i) ditto > LayoutTests/inspector/styles/set-property-boundaries.html:51 > + CSSAgent.setPropertyText(style.styleId, 10, "color:blue;", true, dumpErrorMessage); Maybe const outOfBOundsRuleIndex = 42; ?
Pavel Feldman
Comment 4 2012-03-05 07:03:49 PST
> Could you please use the first item only instead of iterating over all the items? > Done. > > LayoutTests/inspector/styles/set-property-boundaries.html:39 > > + for (var i = 0; i < styleSheet.rules.length; ++i) > > ditto Done. > > > LayoutTests/inspector/styles/set-property-boundaries.html:51 > > + CSSAgent.setPropertyText(style.styleId, 10, "color:blue;", true, dumpErrorMessage); > > Maybe const outOfBOundsRuleIndex = 42; ? Done.
Pavel Feldman
Comment 5 2012-03-05 07:08:18 PST
Committed r109741: <http://trac.webkit.org/changeset/109741>
Note You need to log in before you can comment on or make changes to this bug.