Bug 80255 - Optimize for IPP in DirectConvolver::process()
Summary: Optimize for IPP in DirectConvolver::process()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 75564
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-05 01:45 PST by Xingnan Wang
Modified: 2012-03-23 11:14 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.96 KB, patch)
2012-03-21 04:13 PDT, Xingnan Wang 		no flags Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2012-03-21 20:18 PDT, Xingnan Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xingnan Wang 2012-03-05 01:45:21 PST 
reverb function in ipp library can be used.
Comment 1 Xingnan Wang 2012-03-21 04:13:11 PDT 
Created attachment 133008 [details]
Patch
Comment 2 Xingnan Wang 2012-03-21 04:13:43 PDT 
(In reply to comment #1)
> Created an attachment (id=133008) [details]
> Patch

Uploaded the patch.
Comment 3 Xingnan Wang 2012-03-21 04:14:22 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=133008) [details] [details]
> > Patch
> 
> Uploaded the patch.

Increase ~2X performance by conv() in IPP.
Comment 4 Chris Rogers 2012-03-21 10:53:39 PDT 
Comment on attachment 133008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133008&action=review

Xingnan, thanks for the patch.  Have you run the convolution layout tests when WEBAUDIO_IPP is enabled?  Also, please make sure to call m_overlayBuffer.zero() in the reset() method...

> Source/WebCore/platform/audio/DirectConvolver.cpp:74
> +    float* outputBuffer = m_inputBuffer.data();

It might make sense to rename this member variable more generally now: m_inputBuffer -> m_buffer
since it's a bit confusing to see line 74
Comment 5 Xingnan Wang 2012-03-21 20:18:10 PDT 
Created attachment 133177 [details]
Patch
Comment 6 Xingnan Wang 2012-03-21 20:20:35 PDT 
(In reply to comment #4)
> (From update of attachment 133008 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133008&action=review
> 
> Xingnan, thanks for the patch.  Have you run the convolution layout tests when WEBAUDIO_IPP is enabled?  Also, please make sure to call m_overlayBuffer.zero() in the reset() method...
> 
All layout tests passed when WEBAUDIO_IPP is enabled, both Debug and Release build.
> > Source/WebCore/platform/audio/DirectConvolver.cpp:74
> > +    float* outputBuffer = m_inputBuffer.data();
> 
> It might make sense to rename this member variable more generally now: m_inputBuffer -> m_buffer
> since it's a bit confusing to see line 74
Done.
Comment 7 Chris Rogers 2012-03-23 10:29:48 PDT 
Comment on attachment 133177 [details]
Patch

Thanks!
Comment 8 WebKit Review Bot 2012-03-23 11:14:32 PDT 
Comment on attachment 133177 [details]
Patch

Clearing flags on attachment: 133177

Committed r111880: <http://trac.webkit.org/changeset/111880>
Comment 9 WebKit Review Bot 2012-03-23 11:14:36 PDT 
All reviewed patches have been landed.  Closing bug.