Bug 80253 - REGRESSION(r109294): It broke the unittest of master.cfg
Summary: REGRESSION(r109294): It broke the unittest of master.cfg
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 01:26 PST by Csaba Osztrogonác
Modified: 2012-03-06 04:25 PST (History)
4 users (show)

See Also:

Attachments
proposed fix (2.70 KB, patch)
2012-03-05 01:32 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-03-05 01:26:42 PST 
/usr/lib/python2.6/dist-packages/twisted/mail/smtp.py:10: DeprecationWarning: the MimeWriter module is deprecated; use the email package instead
  import MimeWriter, tempfile, rfc822
Traceback (most recent call last):
  File "./mastercfg_unittest.py", line 321, in <module>
    BuildBotConfigLoader().load_config('master.cfg')
  File "./mastercfg_unittest.py", line 48, in load_config
    execfile(master_cfg_path, globals(), globals())
  File "master.cfg", line 870, in <module>
    loadBuilderConfig(c)
  File "master.cfg", line 807, in loadBuilderConfig
    passwords = json.load(open('passwords.json'))
  File "./mastercfg_unittest.py", line 26, in _mock_open
    return StringIO.StringIO(simplejson.dumps(self._create_mock_passwords_dict()))
NameError: global name 'simplejson' is not defined


Patch is coming soon.
Comment 1 Csaba Osztrogonác 2012-03-05 01:32:45 PST 
Created attachment 130079 [details]
proposed fix
Comment 3 Csaba Osztrogonác 2012-03-06 04:25:36 PST 
Landed in http://trac.webkit.org/changeset/109902