Bug 80251 – GraphicsContext3D.h should include RefCounted.h explicitly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Leo Yang]

GraphicsContext3D.h is using RefCounted but including RefCounted.h indirectly. For some configuration, the indirect include may be failing. We should include the header explicitly anyway.

[Leo Yang]

Created attachment 130080 [details]
Patch

[Rob Buis]

Comment on attachment 130080 [details]
Patch

This is touching cross-platform code! Can you give a concrete example where it fails to compile?

[Leo Yang]

(In reply to comment #2)
> (From update of attachment 130080 [details])
> This is touching cross-platform code! Can you give a concrete example where it fails to compile?

Build blackberry porting for x86 configuration. Note that the upstreamed IntSize.h (not including 2 unnecessary inclusion of PlatformString.h and CString.h which are in the internal version of IntSize.h) was used. This patch is to prepare for removing the 2 unnecessary inclusion in the internal IntSize.h.

[  9%] Building CXX object WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/GraphicsContext3DSkia.cpp.o
[  9%] Building CXX object WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/ImageBufferSkia.cpp.o
[  9%] Building CXX object WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/NativeImageSkia.cpp.o
[  9%] Building CXX object WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/PlatformContextSkia.cpp.o
In file included from /home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:36:0:
/home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/GraphicsContext3D.h:123:44: error: expected template-name before '<' token
/home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/GraphicsContext3D.h:123:44: error: expected '{' before '<' token
/home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/GraphicsContext3D.h:123:44: error: expected unqualified-id before '<' token
/home/leo/workspace/playbook/webkit/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:130:1: error: expected '}' at end of input
cc: /opt/bbndk-2.0.0-beta1/host/linux/x86/usr/lib/gcc/i486-pc-nto-qnx6.5.0/4.6.2/cc1plus error 1
make[2]: *** [WebCore/CMakeFiles/webcore.dir/platform/graphics/skia/NativeImageSkia.cpp.o] Error 1

[Rob Buis]

Comment on attachment 130080 [details]
Patch

The change is good since GraphicsContext3D does derive from RefCounted and relying indirectly is not pretty. But please update the ChangeLog saying the indirection goes through Animation.h and why it does not work for us.

[Leo Yang]

(In reply to comment #4)
> (From update of attachment 130080 [details])
> The change is good since GraphicsContext3D does derive from RefCounted and relying indirectly is not pretty. But please update the ChangeLog saying the indirection goes through Animation.h and why it does not work for us.

Thanks. I'll explain more in the ChangeLog

[Leo Yang]

Created attachment 130264 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 130264 [details]
Patch for landing

Clearing flags on attachment: 130264

Committed r109841: <http://trac.webkit.org/changeset/109841>