Bug 80248 - Geolocation should use a ScriptExecutionContext as its context object
Summary: Geolocation should use a ScriptExecutionContext as its context object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 79327
  Show dependency tree / graph
 
Reported: 2012-03-05 00:31 PST by Adam Barth
Modified: 2012-03-23 17:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.17 KB, patch)
2012-03-05 00:47 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (14.93 KB, patch)
2012-03-05 09:41 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-03-05 00:31:10 PST 
Geolocation should use a ScriptExecutionContext as its context object
Comment 1 Adam Barth 2012-03-05 00:47:50 PST 
Created attachment 130068 [details]
Patch
Comment 2 Build Bot 2012-03-05 02:23:29 PST 
Comment on attachment 130068 [details]
Patch

Attachment 130068 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11803899
Comment 3 Adam Barth 2012-03-05 09:41:11 PST 
Created attachment 130155 [details]
Patch for landing
Comment 4 Adam Barth 2012-03-05 10:18:03 PST 
Committed r109761: <http://trac.webkit.org/changeset/109761>
Comment 5 Csaba Osztrogonác 2012-03-05 22:38:57 PST 
Reopen, because it broke the --minimal build:
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(NavigatorGeolocation.o): in function WebCore::NavigatorGeolocation::geolocation() const:NavigatorGeolocation.cpp(.text._ZNK7WebCore20NavigatorGeolocation11geolocationEv+0x57): error: undefined reference to 'WebCore::Geolocation::create(WebCore::ScriptExecutionContext*)'
c
Comment 6 Eric Seidel (no email) 2012-03-05 22:42:34 PST 
We should consider adding a --minimal EWS bot to prevent such breakages.
Comment 7 Adam Barth 2012-03-05 23:25:35 PST 
Thanks.  Will fix in a moment when my working copy is free.
Comment 8 Adam Barth 2012-03-05 23:54:50 PST 
Fix in https://bugs.webkit.org/show_bug.cgi?id=80390
Comment 9 Adam Barth 2012-03-23 17:25:53 PDT 
This is fixed.