Bug 80243 - Refactoring: Move HTMLContentElement::attach to InsertionPoint::attach
Summary: Refactoring: Move HTMLContentElement::attach to InsertionPoint::attach
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-04 23:43 PST by Shinya Kawanaka
Modified: 2012-03-05 00:22 PST (History)
0 users

See Also:

Attachments
Patch (5.38 KB, patch)
2012-03-05 00:08 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch for landing (5.38 KB, patch)
2012-03-05 00:20 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-03-04 23:43:01 PST 
Since <shadow> will have to do almost the same thing for <content>, it's natural that InsertionPoint::attach() has the same code as HTMLContentElemetn::attach().
Comment 1 Shinya Kawanaka 2012-03-05 00:08:15 PST 
Created attachment 130063 [details]
Patch
Comment 2 Hajime Morrita 2012-03-05 00:16:45 PST 
Comment on attachment 130063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130063&action=review

> Source/WebCore/ChangeLog:9
> +        elements. So it is natural that InsertionPoint::attach() has such code.

Doesn't need "so". Could be single sentence?
Comment 3 Shinya Kawanaka 2012-03-05 00:20:13 PST 
Created attachment 130064 [details]
Patch for landing
Comment 4 Shinya Kawanaka 2012-03-05 00:22:56 PST 
Committed r109718: <http://trac.webkit.org/changeset/109718>