Bug 80239 – [Forms] The "legend" element should not be a form-associated element.

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

According the specification, the "legend" element isn't a form-associate element.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#form-associated-element

However, current implementation of HTMLLegendElement is derived from HTMLFormControlElement. We have unexpected dependency between HTMLLegendElement and HTMLFormControlElement and FormAssociatedElement. Also, We waste time in loop of HTMLFormElement::m_associatedElements.

For clear understanding and better maintainability, it is better that C++ class hierarchy should be similar to specified in the specification.

Created attachment 130299 [details]
Patch 1

This bug is part of HTMLFormControlElement re-factoring bug https://bugs.webkit.org/show_bug.cgi?id=80381

[Kent Tamura]

Comment on attachment 130299 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=130299&action=review

The code change looks ok.

> Source/WebCore/ChangeLog:9
> +        This patch changes base class of HTMLLegendElement to HTMLElement from
> +        HTMLFormControlElement. 

You should mention a reason why we should change this.

Created attachment 130500 [details]
Patch 2

[Kent Tamura]

Comment on attachment 130500 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=130500&action=review

> Source/WebCore/ChangeLog:10
> +        This patch changes base class of HTMLLegendElement to HTMLElement from
> +        HTMLFormControlElement to match C++ class hierarchy to the specification
> +        and to be out from FormAssociatedElement class tree.

So, why we should follow the class hierarchy in the specification? Why HTMLLegendElement should not inherit from FormAssociatedElement?
You should say the benefit of the change.

Created attachment 130524 [details]
Patch 3

[Kent Tamura]

Comment on attachment 130524 [details]
Patch 3

ok

[WebKit Review Bot]

Comment on attachment 130524 [details]
Patch 3

Clearing flags on attachment: 130524

Committed r110029: <http://trac.webkit.org/changeset/110029>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.