Bug 80225 – Web Inspector: CSS inactive property check should account for vendor prefixes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

Created attachment 130030 [details]
Test case

Given this CSS, only "opacity" is active. The others should be inactive.

	-apple-opacity: 0.75;
	-khtml-opacity: 0.25;
	-webkit-opacity: 0.5;
	opacity: 1;

I think InspectorStyle::populateObjectWithStyleProperties is responsible for marking these properties as inactive.

[Timothy Hatcher]

In the real world I ran into this on http://theverge.com where they specify many properties with prefixes for multiple vendors and without prefixes. A common practice for advanced CSS3 sites.

[Timothy Hatcher]

Note: -apple-, and -khtml- are supported by WebKit. Though I think internally they get turned into -webkit- by the parser.

[Alexander Pavlov (apavlov)]

Created attachment 130121 [details]
Patch

[Pavel Feldman]

Comment on attachment 130121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130121&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:484
> +                CSSPropertyID propertyId = static_cast<CSSPropertyID>(cssPropertyID(name));

This does not seem to cover the computed style trace.

> LayoutTests/inspector/elements/elements-panel-styles-expected.txt:13
> +    .foo, .foo::before - blue elements-panel-styles.css:25

Please prefer adding new tests for new features / regressions.

[Alexander Pavlov (apavlov)]

Created attachment 130151 [details]
Patch

[Alexander Pavlov (apavlov)]

Created attachment 130152 [details]
[PATCH] Test expectation updated

[WebKit Review Bot]

Comment on attachment 130152 [details]
[PATCH] Test expectation updated

Clearing flags on attachment: 130152

Committed r109772: <http://trac.webkit.org/changeset/109772>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.