RESOLVED FIXED 80211
[EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate 
https://bugs.webkit.org/show_bug.cgi?id=80211
Summary [EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate
Hyowon Kim
Reported 2012-03-03 01:51:55 PST
The last patch for GC3DPrivate implementation, which contains initialize() and the destructor function using Evas_GL APIs.
Attachments
Patch (12.03 KB, patch)
2012-03-03 01:55 PST, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
proposed patch (6.66 KB, patch)
2012-03-03 02:04 PST, Hyowon Kim 		noam: review-
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
modified patch (7.07 KB, patch)
2012-03-04 00:59 PST, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hyowon Kim
Comment 1 2012-03-03 01:55:20 PST
Created attachment 129998 [details] Patch
Hyowon Kim
Comment 2 2012-03-03 02:04:08 PST
Created attachment 129999 [details] proposed patch
WebKit Review Bot
Comment 3 2012-03-03 04:00:16 PST
Comment on attachment 129999 [details] proposed patch Attachment 129999 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11799322 New failing tests: editing/selection/select-line-break-with-opposite-directionality.html
Noam Rosenthal
Comment 4 2012-03-03 07:46:56 PST
Comment on attachment 129999 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=129999&action=review > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:58 > + if (m_evasGL) { Style: early-return here. > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:87 > + m_context = evas_gl_context_create(m_evasGL, 0); What does 0 stand for? comment. > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:102 > + int x = 0, y = 0, width = 1, height = 1; separate lines.
Hyowon Kim
Comment 5 2012-03-04 00:59:50 PST
Created attachment 130018 [details] modified patch I've added some codes for context sharing between AC and WebGL.
WebKit Review Bot
Comment 6 2012-03-04 19:15:32 PST
Comment on attachment 130018 [details] modified patch Clearing flags on attachment: 130018 Committed r109696: <http://trac.webkit.org/changeset/109696>
WebKit Review Bot
Comment 7 2012-03-04 19:15:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.