Bug 80201 – [chromium] more comprehensive tests for gesture scrolling

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Robert Kroeger]

I am planning to refactor part of the code in WebCore than scrolls in response to arriving GestureScroll* to correctly handle GestureScrollBegin and GestureScrollEnd events. This patch adds some tests to ensure that the refactor will not alter the (currently correct) behaviour of GestureScrollUpdate events.

[Robert Kroeger]

Created attachment 129980 [details]
Patch

[Adam Barth]

Comment on attachment 129980 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 129980 [details]
Patch

Rejecting attachment 129980 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
_by_email
    return self._reviewer_only(self.account_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email
    return self._email_to_account_map().get(email.lower()) if email else None
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map
    assert(email not in self._accounts_by_email)  # We should never have duplicate emails.
AssertionError

Full output: http://queues.webkit.org/results/11807023

[WebKit Review Bot]

Comment on attachment 129980 [details]
Patch

Attachment 129980 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11799208

New failing tests:
fast/events/touch/gesture/touch-gesture-scroll-shy-target.html

[Robert Kroeger]

The tests need to be adjusted for the changed in 80075. New patch forthcoming.

[Robert Kroeger]

Created attachment 130860 [details]
Patch

[Robert Kroeger]

abarth: please take another look.

[WebKit Review Bot]

Comment on attachment 130860 [details]
Patch

Clearing flags on attachment: 130860

Committed r110240: <http://trac.webkit.org/changeset/110240>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.