Bug 80201 - [chromium] more comprehensive tests for gesture scrolling
Summary: [chromium] more comprehensive tests for gesture scrolling
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
Depends on: 80075
Blocks: 67822 80311
  Show dependency treegraph
Reported: 2012-03-02 16:26 PST by Robert Kroeger
Modified: 2012-03-08 17:27 PST (History)
3 users (show)

See Also:

Patch (25.23 KB, patch)
2012-03-02 16:44 PST, Robert Kroeger
no flags Details | Formatted Diff | Diff
Patch (26.02 KB, patch)
2012-03-08 11:18 PST, Robert Kroeger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-03-02 16:26:29 PST
I am planning to refactor part of the code in WebCore than scrolls in response to arriving GestureScroll* to correctly handle GestureScrollBegin and GestureScrollEnd events. This patch adds some tests to ensure that the refactor will not alter the (currently correct) behaviour of GestureScrollUpdate events.
Comment 1 Robert Kroeger 2012-03-02 16:44:01 PST
Created attachment 129980 [details]
Comment 2 Adam Barth 2012-03-02 16:46:21 PST
Comment on attachment 129980 [details]

Comment 3 WebKit Review Bot 2012-03-02 18:45:26 PST
Comment on attachment 129980 [details]

Rejecting attachment 129980 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
    return self._reviewer_only(self.account_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email
    return self._email_to_account_map().get(email.lower()) if email else None
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map
    assert(email not in self._accounts_by_email)  # We should never have duplicate emails.

Full output: http://queues.webkit.org/results/11807023
Comment 4 WebKit Review Bot 2012-03-02 18:47:45 PST
Comment on attachment 129980 [details]

Attachment 129980 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11799208

New failing tests:
Comment 5 Robert Kroeger 2012-03-04 13:20:00 PST
The tests need to be adjusted for the changed in 80075. New patch forthcoming.
Comment 6 Robert Kroeger 2012-03-08 11:18:53 PST
Created attachment 130860 [details]
Comment 7 Robert Kroeger 2012-03-08 11:45:24 PST
abarth: please take another look.
Comment 8 WebKit Review Bot 2012-03-08 17:27:45 PST
Comment on attachment 130860 [details]

Clearing flags on attachment: 130860

Committed r110240: <http://trac.webkit.org/changeset/110240>
Comment 9 WebKit Review Bot 2012-03-08 17:27:51 PST
All reviewed patches have been landed.  Closing bug.