Bug 80196 – Replace uses of x(), y() and width(), height() pairs with locationOffset and size()

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

We still have a handful of places in the code where we use x, y and width, height pairs instead of Points and Sizes.

[Emil A Eklund]

Created attachment 129970 [details]
Patch

[Julien Chaffraix]

Comment on attachment 129970 [details]
Patch

Nit: In HTMLCanvasElement, this line could welcome the same change: FloatRect r = mapRect(rect, FloatRect(0, 0, size().width(), size().height()), destRect);

Also there are other places where we could use the same pattern (like IntRect(0, 0, someComputedHeight, someComputedWidth) in the rendering code) so it seems as if the title is misleading IMHO.

[Emil A Eklund]

Thanks! I'll make the suggested changes to HTMLCanvasElement and have renamed the bug to make it clear what I am changing.

[Julien Chaffraix]

(In reply to comment #3)
> Thanks! I'll make the suggested changes to HTMLCanvasElement and have renamed the bug to make it clear what I am changing.

It makes it a little bit clearer but what I had in mind was not to use 'remaining' as there are some remaining use after your change (look at RenderScrollbar.cpp for example).

[Emil A Eklund]

Good point. Grep failed to find some of the computed value ones. I'll take care of the ones in RenderScrollbar and have updated the summary as suggested.

[Emil A Eklund]

Created attachment 130174 [details]
Patch for landing

[Eric Seidel (no email)]

Comment on attachment 130174 [details]
Patch for landing

These changes are so fantastic.  Thank you.

[WebKit Review Bot]

Comment on attachment 130174 [details]
Patch for landing

Clearing flags on attachment: 130174

Committed r109805: <http://trac.webkit.org/changeset/109805>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.