RESOLVED FIXED 80192
[Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h 
https://bugs.webkit.org/show_bug.cgi?id=80192
Summary [Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h
Takashi Toyoshima
Reported 2012-03-02 14:02:08 PST
WebKit/chromium/src/WebSocketImpl.h doesn't use OVERRIDE macro. Also binaryType() lack 'virtual' declaration.
Attachments
Patch (3.19 KB, patch)
2012-03-02 14:07 PST, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2012-03-02 14:07:30 PST
Created attachment 129956 [details] Patch
Kent Tamura
Comment 2 2012-03-02 17:23:03 PST
Comment on attachment 129956 [details] Patch ok
WebKit Review Bot
Comment 3 2012-03-02 18:43:00 PST
Comment on attachment 129956 [details] Patch Rejecting attachment 129956 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: _by_email return self._reviewer_only(self.account_by_email(email)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email return self._email_to_account_map().get(email.lower()) if email else None File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map assert(email not in self._accounts_by_email) # We should never have duplicate emails. AssertionError Full output: http://queues.webkit.org/results/11803226
Takashi Toyoshima
Comment 4 2012-03-05 09:27:38 PST
Comment on attachment 129956 [details] Patch try cq+ again
WebKit Review Bot
Comment 5 2012-03-05 10:58:00 PST
Comment on attachment 129956 [details] Patch Clearing flags on attachment: 129956 Committed r109771: <http://trac.webkit.org/changeset/109771>
WebKit Review Bot
Comment 6 2012-03-05 10:58:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.