Bug 80192 - [Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h
Summary: [Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Takashi Toyoshima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-02 14:02 PST by Takashi Toyoshima
Modified: 2012-03-05 10:58 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2012-03-02 14:07 PST, Takashi Toyoshima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Toyoshima 2012-03-02 14:02:08 PST 
WebKit/chromium/src/WebSocketImpl.h doesn't use OVERRIDE macro.
Also binaryType() lack 'virtual' declaration.
Comment 1 Takashi Toyoshima 2012-03-02 14:07:30 PST 
Created attachment 129956 [details]
Patch
Comment 2 Kent Tamura 2012-03-02 17:23:03 PST 
Comment on attachment 129956 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-03-02 18:43:00 PST 
Comment on attachment 129956 [details]
Patch

Rejecting attachment 129956 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
_by_email
    return self._reviewer_only(self.account_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email
    return self._email_to_account_map().get(email.lower()) if email else None
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map
    assert(email not in self._accounts_by_email)  # We should never have duplicate emails.
AssertionError

Full output: http://queues.webkit.org/results/11803226
Comment 4 Takashi Toyoshima 2012-03-05 09:27:38 PST 
Comment on attachment 129956 [details]
Patch

try cq+ again
Comment 5 WebKit Review Bot 2012-03-05 10:58:00 PST 
Comment on attachment 129956 [details]
Patch

Clearing flags on attachment: 129956

Committed r109771: <http://trac.webkit.org/changeset/109771>
Comment 6 WebKit Review Bot 2012-03-05 10:58:06 PST 
All reviewed patches have been landed.  Closing bug.