Bug 80189 - Basic IndexedDB shared worker test
Summary: Basic IndexedDB shared worker test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-02 13:41 PST by David Grogan
Modified: 2012-03-05 17:42 PST (History)
4 users (show)

See Also:


Attachments
Patch (8.01 KB, patch)
2012-03-02 13:52 PST, David Grogan
no flags Details | Formatted Diff | Diff
Patch (8.01 KB, patch)
2012-03-02 14:46 PST, David Grogan
no flags Details | Formatted Diff | Diff
Patch (7.91 KB, patch)
2012-03-02 15:57 PST, David Grogan
no flags Details | Formatted Diff | Diff
Patch for landing (17.01 KB, patch)
2012-03-05 13:00 PST, David Grogan
no flags Details | Formatted Diff | Diff
fix changelog (7.81 KB, patch)
2012-03-05 13:12 PST, David Grogan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-03-02 13:41:44 PST
Basic IndexedDB shared worker test
Comment 1 David Grogan 2012-03-02 13:52:09 PST
Created attachment 129953 [details]
Patch
Comment 2 David Grogan 2012-03-02 14:46:12 PST
Created attachment 129959 [details]
Patch
Comment 3 David Grogan 2012-03-02 15:57:45 PST
Created attachment 129974 [details]
Patch
Comment 4 David Grogan 2012-03-02 17:13:46 PST
Tony, could you review this?

Josh and Michael, comments welcome.

This test will be enabled in https://chromiumcodereview.appspot.com/9585031/
Comment 5 Tony Chang 2012-03-05 11:21:04 PST
Comment on attachment 129974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129974&action=review

> LayoutTests/fast/js/resources/js-test-pre.js:476
> +        worker.port.onmessage = function(evt) { worker.onmessage(evt); };

Nit: evt -> event

> LayoutTests/storage/indexeddb/resources/shared.js:7
> +    self.postMessage = function(msg)

Nit: msg -> message

> LayoutTests/storage/indexeddb/resources/shared.js:12
> +    }

Nit: semicolon

> LayoutTests/storage/indexeddb/resources/shared.js:24
> +    }

Nit: semicolon
Comment 6 David Grogan 2012-03-05 13:00:30 PST
Created attachment 130187 [details]
Patch for landing
Comment 7 David Grogan 2012-03-05 13:12:55 PST
Created attachment 130191 [details]
fix changelog
Comment 8 WebKit Review Bot 2012-03-05 17:42:16 PST
Comment on attachment 130191 [details]
fix changelog

Clearing flags on attachment: 130191

Committed r109828: <http://trac.webkit.org/changeset/109828>
Comment 9 WebKit Review Bot 2012-03-05 17:42:21 PST
All reviewed patches have been landed.  Closing bug.