Bug 80188 - Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
Summary: Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode(...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks: 75069
  Show dependency tree / graph
 
Reported: 2012-03-02 13:37 PST by Caio Marcelo de Oliveira Filho
Modified: 2012-03-02 14:59 PST (History)
0 users

See Also:

Attachments
Patch (5.53 KB, patch)
2012-03-02 13:41 PST, Caio Marcelo de Oliveira Filho 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2012-03-02 13:37:36 PST 
Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
Comment 1 Caio Marcelo de Oliveira Filho 2012-03-02 13:41:09 PST 
Created attachment 129951 [details]
Patch
Comment 2 Ryosuke Niwa 2012-03-02 14:13:00 PST 
Comment on attachment 129951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129951&action=review

> Source/WebCore/dom/NamedNodeMap.cpp:108
> +    Attr* attr = static_cast<Attr*>(node);
> +    return m_element->setAttributeNode(attr, ec);

Do we really need a local variable?
Comment 3 Caio Marcelo de Oliveira Filho 2012-03-02 14:59:59 PST 
Committed r109619: <http://trac.webkit.org/changeset/109619>