Bug 80180 – links for virtual tests are broken in the flakiness dashboard

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

links for virtual tests are broken in the flakiness dashboard

[Dirk Pranke]

Created attachment 129936 [details]
Patch

[Dirk Pranke]

It looks like there is only one minor tweak needed to make the flakiness dashboard work with virtual tests - it mostly works now, just the link to the test in trac is broken.

It turns out we got "lucky" in that the flakiness dashboard only looks at the results of the run, and by the time links end up in the results the actual/virtual distinction is gone (all tests look the same).

[Dirk Pranke]

How do I run tests for this, and does it make sense to add a test for this?

[Ojan Vafai]

Comment on attachment 129936 [details]
Patch

Please do add a test. The test suite for this code is pretty...bare, but testing this specific thing should be easy enough. The tests are in flakiness_dashboard_tests.js, you run them in the browser by loading flakiness_dashboard#useTestData=true off your local disk. It's wonky, but good enough for now. :)

Did you test loading the expected results for the test, e.g. a page like http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fjs%2Fnavigator-language.html? The test itself should be one of the frames. Also, we show all the expected results in the fallback order. How does the fallback order for virtual tests work? You probably need to update that code as well.

[Dirk Pranke]

(In reply to comment #3)
> How do I run tests for this, and does it make sense to add a test for this?

(In reply to comment #4)
> (From update of attachment 129936 [details])
> Please do add a test. The test suite for this code is pretty...bare, but testing this specific thing should be easy enough. The tests are in flakiness_dashboard_tests.js, you run them in the browser by loading flakiness_dashboard#useTestData=true off your local disk. It's wonky, but good enough for now. :)
> 

Will do.

> Did you test loading the expected results for the test, e.g. a page like http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fjs%2Fnavigator-language.html? The test itself should be one of the frames. Also, we show all the expected results in the fallback order. How does the fallback order for virtual tests work? You probably need to update that code as well.

Hm. I thought I did and it looked like it was working, but when I look at it now, I'm not seeing them. I will work on it some more as a different bug/patch.

[Dirk Pranke]

Created attachment 129946 [details]
Patch

[Dirk Pranke]

Comment on attachment 129946 [details]
Patch

Clearing flags on attachment: 129946

Committed r109606: <http://trac.webkit.org/changeset/109606>

[Dirk Pranke]

All reviewed patches have been landed.  Closing bug.