Bug 80178 – allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext

[Adam Barth]

Created attachment 129935 [details]
Patch

[Build Bot]

Comment on attachment 129935 [details]
Patch

Attachment 129935 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11799076

[Build Bot]

Comment on attachment 129935 [details]
Patch

Attachment 129935 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11796111

[Early Warning System Bot]

Comment on attachment 129935 [details]
Patch

Attachment 129935 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11803071

[Adam Barth]

Created attachment 129948 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 129948 [details]
Patch

OK.  I assume that Suplement<T> takes care of all the details of making sure that these supelemnts (like DatabaseContext) never outlive their Suplementables?

[Adam Barth]

> OK.  I assume that Suplement<T> takes care of all the details of making sure that these supelemnts (like DatabaseContext) never outlive their Suplementables?

Yes.  The Suplement object is owned by the Suplementable object.

[WebKit Review Bot]

Comment on attachment 129948 [details]
Patch

Rejecting attachment 129948 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
_by_email
    return self._reviewer_only(self.account_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email
    return self._email_to_account_map().get(email.lower()) if email else None
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map
    assert(email not in self._accounts_by_email)  # We should never have duplicate emails.
AssertionError

Full output: http://queues.webkit.org/results/11801210

[WebKit Review Bot]

Comment on attachment 129948 [details]
Patch

Clearing flags on attachment: 129948

Committed r109716: <http://trac.webkit.org/changeset/109716>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.