Bug 80175 – Revert borders to integers for subpixel layout

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Change border representation and calculation back to integers to ensure that borders given the same width are rendered with the same actual width. This also avoids unnecessary type conversions.

[Emil A Eklund]

Created attachment 129931 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 129931 [details]
Patch

hmm... So even table borders are not sub-pixel precise?  I know individual cell-layout for tables is done with integers... but I'm surprised that borders around said table would be?

[Emil A Eklund]

(In reply to comment #2)
> (From update of attachment 129931 [details])
> hmm... So even table borders are not sub-pixel precise?  I know individual cell-layout for tables is done with integers... but I'm surprised that borders around said table would be?

Borders are aligned to device pixels to ensure that a box with border a style such as "0.3ex solid black" has all four borders rendered with the same width regardless of the offset. If we did this with subpixel precision the bottom/right border might be pained width a different width.

[WebKit Review Bot]

Comment on attachment 129931 [details]
Patch

Attachment 129931 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11799129

New failing tests:
editing/selection/select-line-break-with-opposite-directionality.html

[WebKit Review Bot]

Comment on attachment 129931 [details]
Patch

Clearing flags on attachment: 129931

Committed r109642: <http://trac.webkit.org/changeset/109642>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.