RESOLVED FIXED80169
Create a method in Element to compare attributes with other Element 
https://bugs.webkit.org/show_bug.cgi?id=80169
Summary Create a method in Element to compare attributes with other Element
Caio Marcelo de Oliveira Filho
Reported 2012-03-02 10:12:10 PST
Create a method in Element to compare attributes with other Element
Attachments
Patch (7.68 KB, patch)
2012-03-02 10:18 PST, Caio Marcelo de Oliveira Filho 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2012-03-02 10:18:19 PST
Created attachment 129918 [details] Patch
Ryosuke Niwa
Comment 2 2012-03-02 10:26:19 PST
Comment on attachment 129918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129918&action=review > Source/WebCore/dom/Node.cpp:1775 > + if (isElementNode() && !toElement(this)->hasEquivalentAttributes(toElement(other))) Maybe we should an inline helper that takes Node* and returns false when its' not an element? That'll avoid having to cast nodes. > Source/WebCore/editing/htmlediting.cpp:1161 > + if (!firstElement->tagQName().matches(secondElement->tagQName())) Can't we do firstElement->hasTagQName(secondElement->tagQName()) ? Maybe this is slower?
Ryosuke Niwa
Comment 3 2012-03-02 10:26:40 PST
This is a very nice refactoring!
Caio Marcelo de Oliveira Filho
Comment 4 2012-03-02 11:02:23 PST
Committed r109585: <http://trac.webkit.org/changeset/109585>
Philippe Normand
Comment 5 2012-03-02 11:33:02 PST
(In reply to comment #4) > Committed r109585: <http://trac.webkit.org/changeset/109585> Broke the GTK build :(
Philippe Normand
Comment 6 2012-03-02 11:37:48 PST
(In reply to comment #5) > (In reply to comment #4) > > Committed r109585: <http://trac.webkit.org/changeset/109585> > > Broke the GTK build :( Sorry it seems to be a false alarm, the 64-bit Release bot looks hosed, let's try a full clean build.
Note You need to log in before you can comment on or make changes to this bug.