Bug 80144 - Revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl
Summary: Revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 79327
  Show dependency treegraph
 
Reported: 2012-03-02 04:12 PST by Kentaro Hara
Modified: 2012-03-04 18:25 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.26 KB, patch)
2012-03-02 04:22 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for landing (9.32 KB, patch)
2012-03-04 16:49 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-03-02 04:12:53 PST
Based on the discussion on webkit-dev@ (http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results), we should revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl.
Comment 1 Kentaro Hara 2012-03-02 04:22:03 PST
Created attachment 129875 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-02 15:41:35 PST
Comment on attachment 129875 [details]
Patch

Rejecting attachment 129875 [details] from commit-queue.

New failing tests:
editing/selection/select-line-break-with-opposite-directionality.html
Full output: http://queues.webkit.org/results/11795192
Comment 3 WebKit Review Bot 2012-03-02 16:01:02 PST
Comment on attachment 129875 [details]
Patch

Rejecting attachment 129875 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
oj
Hunk #1 FAILED at 10803.
Hunk #2 succeeded at 14591 (offset 4 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/html/canvas/DOMWindowWebGL.idl
rm 'Source/WebCore/html/canvas/DOMWindowWebGL.idl'
patching file Source/WebCore/page/DOMWindow.idl

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11801166
Comment 4 Kentaro Hara 2012-03-04 16:49:54 PST
Created attachment 130033 [details]
patch for landing
Comment 5 WebKit Review Bot 2012-03-04 18:24:39 PST
Comment on attachment 130033 [details]
patch for landing

Clearing flags on attachment: 130033

Committed r109691: <http://trac.webkit.org/changeset/109691>