RESOLVED FIXED80143
Web Inspector: update execution line using LiveLocation. 
https://bugs.webkit.org/show_bug.cgi?id=80143
Summary Web Inspector: update execution line using LiveLocation.
Pavel Podivilov
Reported 2012-03-02 04:00:42 PST
Web Inspector: update execution line using LiveLocation.
Attachments
Patch (4.46 KB, patch)
2012-03-02 04:03 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2012-03-02 04:19 PST, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (4.38 KB, patch)
2012-03-02 04:20 PST, Pavel Podivilov 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2012-03-02 04:03:25 PST
Created attachment 129871 [details] Patch
Vsevolod Vlasov
Comment 2 2012-03-02 04:17:23 PST
Comment on attachment 129871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129871&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:547 > + this._exectionLineLiveLocation.dispose(); _execUtionLineLiveLocation typo ^ > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:548 > + this._exectionLineLiveLocation = null; This logic should be moved to selectedCallFrame setter, so that you don't need to call dispose twice.
Pavel Podivilov
Comment 3 2012-03-02 04:19:20 PST
Created attachment 129872 [details] Patch
Pavel Podivilov
Comment 4 2012-03-02 04:20:45 PST
Created attachment 129873 [details] Patch
Vsevolod Vlasov
Comment 5 2012-03-02 04:23:25 PST
Comment on attachment 129873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129873&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:559 > + this._executionLineLiveLocation = null; delete this._executionLineLiveLocation ?
Pavel Podivilov
Comment 6 2012-03-02 05:15:38 PST
Committed r109560: <http://trac.webkit.org/changeset/109560>
Note You need to log in before you can comment on or make changes to this bug.