Bug 80143 - Web Inspector: update execution line using LiveLocation.
Summary: Web Inspector: update execution line using LiveLocation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-02 04:00 PST by Pavel Podivilov
Modified: 2012-03-02 05:15 PST (History)
10 users (show)

See Also:


Attachments
Patch (4.46 KB, patch)
2012-03-02 04:03 PST, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2012-03-02 04:19 PST, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch (4.38 KB, patch)
2012-03-02 04:20 PST, Pavel Podivilov
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-03-02 04:00:42 PST
Web Inspector: update execution line using LiveLocation.
Comment 1 Pavel Podivilov 2012-03-02 04:03:25 PST
Created attachment 129871 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-02 04:17:23 PST
Comment on attachment 129871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129871&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:547
> +        this._exectionLineLiveLocation.dispose();

_execUtionLineLiveLocation
typo ^

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:548
> +        this._exectionLineLiveLocation = null;

This logic should be moved to selectedCallFrame setter, so that you don't need to call dispose twice.
Comment 3 Pavel Podivilov 2012-03-02 04:19:20 PST
Created attachment 129872 [details]
Patch
Comment 4 Pavel Podivilov 2012-03-02 04:20:45 PST
Created attachment 129873 [details]
Patch
Comment 5 Vsevolod Vlasov 2012-03-02 04:23:25 PST
Comment on attachment 129873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129873&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:559
> +        this._executionLineLiveLocation = null;

delete this._executionLineLiveLocation ?
Comment 6 Pavel Podivilov 2012-03-02 05:15:38 PST
Committed r109560: <http://trac.webkit.org/changeset/109560>