We should implement LayoutTestController::clearBackForwardList for the EFL port so that we can unskip some history feature tests.
Created attachment 129876 [details] V1:Patch Implemented LayoutTestController::clearBackForwardList and unskipped some of the history feature tests which are passing now.
Comment on attachment 129876 [details] V1:Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129876&action=review Add description to ChangeLog, then request review and commit queue. > Tools/ChangeLog:7 > + You should add description for this patch. > LayoutTests/ChangeLog:7 > + ditto.
Created attachment 131618 [details] Implement clearBackForwardList
Comment on attachment 131618 [details] Implement clearBackForwardList View in context: https://bugs.webkit.org/attachment.cgi?id=131618&action=review > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:75 > + const int limit = ewk_history_limit_get(history); > + ewk_history_limit_set(history, 0); > + ewk_history_limit_set(history, limit); You can use ewk_history_clear() instead.
Created attachment 131636 [details] New patch fixing comment #4
Comment on attachment 131636 [details] New patch fixing comment #4 Thanks, looks fine to me.
Comment on attachment 131636 [details] New patch fixing comment #4 Clearing flags on attachment: 131636 Committed r110700: <http://trac.webkit.org/changeset/110700>
All reviewed patches have been landed. Closing bug.