Bug 80137 – [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Grzegorz Czajkowski]

Adds implementation LayoutTestController's setPopupBlockingEnabled.

I am working on this, patch will be uploaded.

[Grzegorz Czajkowski]

Created attachment 130314 [details]
proposed patch

This patch:
 - implements LayoutTestController's setPopupBlockingEnabled,
 - enables tests connected with setPopupBlockingEnabled
 - deletes idler which called by scheduleAsynchronousClickCallback (EventSender.cpp), sendClick should be called only once to pass popup-blocking-click-in-iframe.html

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 130314 [details]
proposed patch

Looks fine.

[Gyuyoung Kim]

Comment on attachment 130314 [details]
proposed patch

Looks good too.

[Eric Seidel (no email)]

Comment on attachment 130314 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130314&action=review

LGTM.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:439
> +void LayoutTestController::setPopupBlockingEnabled(bool flag)

Woudl be better to use a nicer name.  Like enablePopupBlocking.

[Grzegorz Czajkowski]

(In reply to comment #4)
> (From update of attachment 130314 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130314&action=review
> 
> LGTM.
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:439
> > +void LayoutTestController::setPopupBlockingEnabled(bool flag)
> 
> Woudl be better to use a nicer name.  Like enablePopupBlocking.

Yes, but this implements a common interface for all WebKit ports (Tools/DumpRenderTree/LayoutTestController.h) We can change it while general refactoring of DRT in my opinion :)

[WebKit Review Bot]

Comment on attachment 130314 [details]
proposed patch

Clearing flags on attachment: 130314

Committed r110028: <http://trac.webkit.org/changeset/110028>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.