Bug 80136 – [EFL][DRT] Implement LayoutTestController's methods related with editing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Grzegorz Czajkowski]

Implements EFL's LayoutTestController methods:
 - setSmartInsertDeleteEnabled,
 - setSelectTrailingWhitespaceEnabled
 - hasSpellingMarker.

I am working on this implementation, patch will be uploaded soon.

[Grzegorz Czajkowski]

Created attachment 130122 [details]
proposed patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 130122 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130122&action=review

I'd rather avoid doing what the Qt port does/used to do and make WebCoreSupport aware of DRT; the current code was written with that in mind, and I think we can keep doing so. Isn't it possible to make DRTSupportEefl::setSelectTrailingWhitespaceEnabled set some flag in EditClient itself or in ewk_view?

> LayoutTests/platform/efl/Skipped:67
> +editing/selection/doubleclick-inline-first-last-contenteditable.html

Please keep the list alphabetically sorted.

[Grzegorz Czajkowski]

Created attachment 130563 [details]
updated patch according to Kubo's review

[Grzegorz Czajkowski]

(In reply to comment #2)
> (From update of attachment 130122 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130122&action=review
> 
> I'd rather avoid doing what the Qt port does/used to do and make WebCoreSupport aware of DRT; the current code was written with that in mind, and I think we can keep doing so. Isn't it possible to make DRTSupportEefl::setSelectTrailingWhitespaceEnabled set some flag in EditClient itself or in ewk_view?

Ok, I added flag to EditorClinetEfl to set/get selectTrailingWhitespaceEnabled (similar to smartInsertDeleteEnabled).

> 
> > LayoutTests/platform/efl/Skipped:67
> > +editing/selection/doubleclick-inline-first-last-contenteditable.html
> 
> Please keep the list alphabetically sorted.

Done.

[Grzegorz Czajkowski]

Created attachment 130568 [details]
rebased patch to HEAD

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 130568 [details]
rebased patch to HEAD

Looks fine to me.

[Ryosuke Niwa]

Comment on attachment 130568 [details]
rebased patch to HEAD

View in context: https://bugs.webkit.org/attachment.cgi?id=130568&action=review

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:235
> +    m_smartInsertDeleteEnabled = enabled;

You also need to set m_selectTrailingWhitespaceEnabled false if enabled was true here.

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:245
> +    m_selectTrailingWhitespaceEnabled = enabled;

You need to set m_smartInsertDeleteEnabled false if enabled was true here.

[Grzegorz Czajkowski]

Created attachment 133254 [details]
updated patch

Added Ryosuke's suggestions.
Removed hasSpellingMarker implementation from current patch - hasSpellingMarker should be used through Internals interface https://bugs.webkit.org/show_bug.cgi?id=81300.

Patch for landing :)

[WebKit Review Bot]

Comment on attachment 133254 [details]
updated patch

Clearing flags on attachment: 133254

Committed r111835: <http://trac.webkit.org/changeset/111835>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.