Bug 80122 - [BlackBerry] Upstream LayerRendererSurface.{cpp, h}
Summary: [BlackBerry] Upstream LayerRendererSurface.{cpp, h}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 73119
  Show dependency tree / graph
 
Reported: 2012-03-02 00:59 PST by Robin Cao
Modified: 2012-03-05 15:50 PST (History)
8 users (show)

See Also:

Attachments
patch (7.66 KB, patch)
2012-03-02 02:04 PST, Robin Cao 		no flags Details | Formatted Diff | Diff
patch-renaming (8.74 KB, patch)
2012-03-05 04:14 PST, Robin Cao 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Cao 2012-03-02 00:59:25 PST 
RenderSurface is the class that acts as an offscreen surface.
Comment 1 Robin Cao 2012-03-02 02:04:17 PST 
Created attachment 129850 [details]
patch
Comment 2 Nikolas Zimmermann 2012-03-02 02:39:05 PST 
Comment on attachment 129850 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129850&action=review

> Source/WebCore/platform/graphics/blackberry/RenderSurface.h:35
> +class RenderSurface {

The name of this class looks weird, it made me think we're dealing with a RenderObject derived class.
Can we come up with a better name? LayerRendererSurface maybe?
Comment 3 Antonio Gomes 2012-03-04 13:07:54 PST 
Comment on attachment 129850 [details]
patch

Agreed with Niko. Lets try renaming it...
Comment 4 Robin Cao 2012-03-05 00:31:37 PST 
RenderSurface wraps an OpenGL texture which is to be rendered by hardware. As far as i can see, it's will only be used in LayerRenderer. So LayerRendererSurface looks much better to me.
Comment 5 Robin Cao 2012-03-05 04:14:39 PST 
Created attachment 130092 [details]
patch-renaming
Comment 6 Early Warning System Bot 2012-03-05 04:35:47 PST 
Comment on attachment 130092 [details]
patch-renaming

Attachment 130092 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11807751
Comment 7 Rob Buis 2012-03-05 13:28:13 PST 
Comment on attachment 130092 [details]
patch-renaming

LGTM.
Comment 8 WebKit Review Bot 2012-03-05 15:50:27 PST 
Comment on attachment 130092 [details]
patch-renaming

Clearing flags on attachment: 130092

Committed r109809: <http://trac.webkit.org/changeset/109809>
Comment 9 WebKit Review Bot 2012-03-05 15:50:43 PST 
All reviewed patches have been landed.  Closing bug.