RESOLVED FIXED 80120
Change the argument orders to match OpenGL's in GraphicsContext3D functions
https://bugs.webkit.org/show_bug.cgi?id=80120
Summary Change the argument orders to match OpenGL's in GraphicsContext3D functions
Changhun Kang
Reported 2012-03-02 00:22:24 PST
Change the argument orders to match OpenGL's in GraphicsContext3D functions
Attachments
Patch (22.98 KB, patch)
2012-03-02 00:23 PST, Changhun Kang
no flags
Patch (24.10 KB, patch)
2012-03-02 00:39 PST, Changhun Kang
no flags
Patch (24.10 KB, patch)
2012-03-02 00:50 PST, Changhun Kang
no flags
Patch (24.17 KB, patch)
2012-03-02 01:10 PST, Changhun Kang
no flags
Patch (24.17 KB, patch)
2012-03-02 01:50 PST, Changhun Kang
no flags
Patch (33.41 KB, patch)
2012-03-02 02:17 PST, Changhun Kang
no flags
Patch (34.35 KB, patch)
2012-03-02 02:47 PST, Changhun Kang
no flags
Patch (37.12 KB, patch)
2012-03-02 16:08 PST, Changhun Kang
no flags
Patch (44.94 KB, patch)
2012-03-03 20:33 PST, Changhun Kang
no flags
Patch (52.07 KB, patch)
2012-03-03 21:51 PST, Changhun Kang
no flags
Patch (56.82 KB, patch)
2012-03-03 22:24 PST, Changhun Kang
no flags
Patch (45.66 KB, patch)
2012-03-05 17:16 PST, Changhun Kang
no flags
Changhun Kang
Comment 1 2012-03-02 00:23:51 PST
WebKit Review Bot
Comment 2 2012-03-02 00:27:49 PST
Attachment 129836 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/GraphicsContext3D.h:760: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/GraphicsContext3D.h:762: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/GraphicsContext3D.h:764: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/GraphicsContext3D.h:766: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/GraphicsContext3D.h:775: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/GraphicsContext3D.h:776: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/GraphicsContext3D.h:777: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Changhun Kang
Comment 3 2012-03-02 00:39:42 PST
Build Bot
Comment 4 2012-03-02 00:43:51 PST
Changhun Kang
Comment 5 2012-03-02 00:50:50 PST
Build Bot
Comment 6 2012-03-02 00:55:55 PST
Changhun Kang
Comment 7 2012-03-02 01:10:08 PST
Build Bot
Comment 8 2012-03-02 01:42:36 PST
Early Warning System Bot
Comment 9 2012-03-02 01:48:13 PST
Changhun Kang
Comment 10 2012-03-02 01:50:13 PST
Early Warning System Bot
Comment 11 2012-03-02 01:59:04 PST
Build Bot
Comment 12 2012-03-02 02:15:34 PST
Changhun Kang
Comment 13 2012-03-02 02:17:59 PST
Build Bot
Comment 14 2012-03-02 02:43:32 PST
Changhun Kang
Comment 15 2012-03-02 02:47:18 PST
WebKit Review Bot
Comment 16 2012-03-02 05:08:52 PST
Comment on attachment 129861 [details] Patch Attachment 129861 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11757931
Zhenyao Mo
Comment 17 2012-03-02 09:34:40 PST
You also need to change the order for the chromium port: Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
Changhun Kang
Comment 18 2012-03-02 16:08:19 PST
WebKit Review Bot
Comment 19 2012-03-02 18:10:56 PST
Comment on attachment 129975 [details] Patch Attachment 129975 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11796240
Kenneth Russell
Comment 20 2012-03-02 18:15:26 PST
Comment on attachment 129975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129975&action=review > Source/WebCore/ChangeLog:10 > + * platform/graphics/GraphicsContext3D.h: To save you time, as you upload new patches and get this to build, please regenerate the ChangeLog so that the list of modified files is consistent.
Changhun Kang
Comment 21 2012-03-03 20:33:12 PST
WebKit Review Bot
Comment 22 2012-03-03 20:56:47 PST
Comment on attachment 130015 [details] Patch Attachment 130015 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11800501
Changhun Kang
Comment 23 2012-03-03 21:51:19 PST
WebKit Review Bot
Comment 24 2012-03-03 22:20:27 PST
Comment on attachment 130016 [details] Patch Attachment 130016 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11803558
Changhun Kang
Comment 25 2012-03-03 22:24:52 PST
Kenneth Russell
Comment 26 2012-03-05 14:35:53 PST
Comment on attachment 130017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130017&action=review The code looks fine; the ChangeLogs need to be updated. r=me, but you'll need to upload a new patch. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) You'll have to remove this line in order for the commit queue to accept this patch. Leave the one above about "Reviewed by NOBODY". > Source/WebCore/ChangeLog:71 > +2012-03-03 Changhun Kang <temoochin@company100.net> This duplicate ChangeLog entry needs to be removed. > Source/WebCore/ChangeLog:141 > +2012-03-03 Changhun Kang <temoochin@company100.net> And this one and throughout this patch.
Changhun Kang
Comment 27 2012-03-05 17:16:48 PST
Kenneth Russell
Comment 28 2012-03-05 17:25:34 PST
Comment on attachment 130242 [details] Patch Thanks, looks fine. r=me
WebKit Review Bot
Comment 29 2012-03-05 20:02:48 PST
Comment on attachment 130242 [details] Patch Clearing flags on attachment: 130242 Committed r109838: <http://trac.webkit.org/changeset/109838>
WebKit Review Bot
Comment 30 2012-03-05 20:02:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.