Bug 80120 – Change the argument orders to match OpenGL's in GraphicsContext3D functions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Changhun Kang]

Change the argument orders to match OpenGL's in GraphicsContext3D functions

[Changhun Kang]

Created attachment 129836 [details]
Patch

[WebKit Review Bot]

Attachment 129836 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/GraphicsContext3D.h:760:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:762:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:764:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:766:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:775:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:776:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:777:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Changhun Kang]

Created attachment 129839 [details]
Patch

[Build Bot]

Comment on attachment 129839 [details]
Patch

Attachment 129839 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11776847

[Changhun Kang]

Created attachment 129840 [details]
Patch

[Build Bot]

Comment on attachment 129840 [details]
Patch

Attachment 129840 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11766837

[Changhun Kang]

Created attachment 129842 [details]
Patch

[Build Bot]

Comment on attachment 129842 [details]
Patch

Attachment 129842 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11757847

[Early Warning System Bot]

Comment on attachment 129842 [details]
Patch

Attachment 129842 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11751845

[Changhun Kang]

Created attachment 129845 [details]
Patch

[Early Warning System Bot]

Comment on attachment 129845 [details]
Patch

Attachment 129845 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11767867

[Build Bot]

Comment on attachment 129845 [details]
Patch

Attachment 129845 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11766878

[Changhun Kang]

Created attachment 129859 [details]
Patch

[Build Bot]

Comment on attachment 129859 [details]
Patch

Attachment 129859 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11776898

[Changhun Kang]

Created attachment 129861 [details]
Patch

[WebKit Review Bot]

Comment on attachment 129861 [details]
Patch

Attachment 129861 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11757931

[Zhenyao Mo]

You also need to change the order for the chromium port:

Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp

[Changhun Kang]

Created attachment 129975 [details]
Patch

[WebKit Review Bot]

Comment on attachment 129975 [details]
Patch

Attachment 129975 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11796240

[Kenneth Russell]

Comment on attachment 129975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129975&action=review

> Source/WebCore/ChangeLog:10
> +        * platform/graphics/GraphicsContext3D.h:

To save you time, as you upload new patches and get this to build, please regenerate the ChangeLog so that the list of modified files is consistent.

[Changhun Kang]

Created attachment 130015 [details]
Patch

[WebKit Review Bot]

Comment on attachment 130015 [details]
Patch

Attachment 130015 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11800501

[Changhun Kang]

Created attachment 130016 [details]
Patch

[WebKit Review Bot]

Comment on attachment 130016 [details]
Patch

Attachment 130016 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11803558

[Changhun Kang]

Created attachment 130017 [details]
Patch

[Kenneth Russell]

Comment on attachment 130017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130017&action=review

The code looks fine; the ChangeLogs need to be updated. r=me, but you'll need to upload a new patch.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You'll have to remove this line in order for the commit queue to accept this patch. Leave the one above about "Reviewed by NOBODY".

> Source/WebCore/ChangeLog:71
> [phone]  Changhun Kang  <[e-mail]>

This duplicate ChangeLog entry needs to be removed.

> Source/WebCore/ChangeLog:141
> [phone]  Changhun Kang  <[e-mail]>

And this one and throughout this patch.

[Changhun Kang]

Created attachment 130242 [details]
Patch

[Kenneth Russell]

Comment on attachment 130242 [details]
Patch

Thanks, looks fine. r=me

[WebKit Review Bot]

Comment on attachment 130242 [details]
Patch

Clearing flags on attachment: 130242

Committed r109838: <http://trac.webkit.org/changeset/109838>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.