Bug 80120 - Change the argument orders to match OpenGL's in GraphicsContext3D functions
Summary: Change the argument orders to match OpenGL's in GraphicsContext3D functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Changhun Kang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-02 00:22 PST by Changhun Kang
Modified: 2012-03-05 20:02 PST (History)
6 users (show)

See Also:

Attachments
Patch (22.98 KB, patch)
2012-03-02 00:23 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (24.10 KB, patch)
2012-03-02 00:39 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (24.10 KB, patch)
2012-03-02 00:50 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (24.17 KB, patch)
2012-03-02 01:10 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (24.17 KB, patch)
2012-03-02 01:50 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (33.41 KB, patch)
2012-03-02 02:17 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (34.35 KB, patch)
2012-03-02 02:47 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (37.12 KB, patch)
2012-03-02 16:08 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (44.94 KB, patch)
2012-03-03 20:33 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (52.07 KB, patch)
2012-03-03 21:51 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (56.82 KB, patch)
2012-03-03 22:24 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Patch (45.66 KB, patch)
2012-03-05 17:16 PST, Changhun Kang 		no flags Details | Formatted Diff | Diff
Show Obsolete (11) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Changhun Kang 2012-03-02 00:22:24 PST 
Change the argument orders to match OpenGL's in GraphicsContext3D functions
Comment 1 Changhun Kang 2012-03-02 00:23:51 PST 
Created attachment 129836 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-02 00:27:49 PST 
Attachment 129836 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/GraphicsContext3D.h:760:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:762:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:764:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:766:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:775:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:776:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:777:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Changhun Kang 2012-03-02 00:39:42 PST 
Created attachment 129839 [details]
Patch
Comment 4 Build Bot 2012-03-02 00:43:51 PST 
Comment on attachment 129839 [details]
Patch

Attachment 129839 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11776847
Comment 5 Changhun Kang 2012-03-02 00:50:50 PST 
Created attachment 129840 [details]
Patch
Comment 6 Build Bot 2012-03-02 00:55:55 PST 
Comment on attachment 129840 [details]
Patch

Attachment 129840 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11766837
Comment 7 Changhun Kang 2012-03-02 01:10:08 PST 
Created attachment 129842 [details]
Patch
Comment 8 Build Bot 2012-03-02 01:42:36 PST 
Comment on attachment 129842 [details]
Patch

Attachment 129842 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11757847
Comment 9 Early Warning System Bot 2012-03-02 01:48:13 PST 
Comment on attachment 129842 [details]
Patch

Attachment 129842 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11751845
Comment 10 Changhun Kang 2012-03-02 01:50:13 PST 
Created attachment 129845 [details]
Patch
Comment 11 Early Warning System Bot 2012-03-02 01:59:04 PST 
Comment on attachment 129845 [details]
Patch

Attachment 129845 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11767867
Comment 12 Build Bot 2012-03-02 02:15:34 PST 
Comment on attachment 129845 [details]
Patch

Attachment 129845 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11766878
Comment 13 Changhun Kang 2012-03-02 02:17:59 PST 
Created attachment 129859 [details]
Patch
Comment 14 Build Bot 2012-03-02 02:43:32 PST 
Comment on attachment 129859 [details]
Patch

Attachment 129859 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11776898
Comment 15 Changhun Kang 2012-03-02 02:47:18 PST 
Created attachment 129861 [details]
Patch
Comment 16 WebKit Review Bot 2012-03-02 05:08:52 PST 
Comment on attachment 129861 [details]
Patch

Attachment 129861 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11757931
Comment 17 Zhenyao Mo 2012-03-02 09:34:40 PST 
You also need to change the order for the chromium port:

Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
Comment 18 Changhun Kang 2012-03-02 16:08:19 PST 
Created attachment 129975 [details]
Patch
Comment 19 WebKit Review Bot 2012-03-02 18:10:56 PST 
Comment on attachment 129975 [details]
Patch

Attachment 129975 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11796240
Comment 20 Kenneth Russell 2012-03-02 18:15:26 PST 
Comment on attachment 129975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129975&action=review

> Source/WebCore/ChangeLog:10
> +        * platform/graphics/GraphicsContext3D.h:

To save you time, as you upload new patches and get this to build, please regenerate the ChangeLog so that the list of modified files is consistent.
Comment 21 Changhun Kang 2012-03-03 20:33:12 PST 
Created attachment 130015 [details]
Patch
Comment 22 WebKit Review Bot 2012-03-03 20:56:47 PST 
Comment on attachment 130015 [details]
Patch

Attachment 130015 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11800501
Comment 23 Changhun Kang 2012-03-03 21:51:19 PST 
Created attachment 130016 [details]
Patch
Comment 24 WebKit Review Bot 2012-03-03 22:20:27 PST 
Comment on attachment 130016 [details]
Patch

Attachment 130016 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11803558
Comment 25 Changhun Kang 2012-03-03 22:24:52 PST 
Created attachment 130017 [details]
Patch
Comment 26 Kenneth Russell 2012-03-05 14:35:53 PST 
Comment on attachment 130017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130017&action=review

The code looks fine; the ChangeLogs need to be updated. r=me, but you'll need to upload a new patch.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You'll have to remove this line in order for the commit queue to accept this patch. Leave the one above about "Reviewed by NOBODY".

> Source/WebCore/ChangeLog:71
> +2012-03-03  Changhun Kang  <temoochin@company100.net>

This duplicate ChangeLog entry needs to be removed.

> Source/WebCore/ChangeLog:141
> +2012-03-03  Changhun Kang  <temoochin@company100.net>

And this one and throughout this patch.
Comment 27 Changhun Kang 2012-03-05 17:16:48 PST 
Created attachment 130242 [details]
Patch
Comment 28 Kenneth Russell 2012-03-05 17:25:34 PST 
Comment on attachment 130242 [details]
Patch

Thanks, looks fine. r=me
Comment 29 WebKit Review Bot 2012-03-05 20:02:48 PST 
Comment on attachment 130242 [details]
Patch

Clearing flags on attachment: 130242

Committed r109838: <http://trac.webkit.org/changeset/109838>
Comment 30 WebKit Review Bot 2012-03-05 20:02:55 PST 
All reviewed patches have been landed.  Closing bug.