Bug 80116 – HTMLTrackElement.idl doesn't have default attribute.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#the-track-element

[Arun Patole]

(In reply to comment #0)
> See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#the-track-element

I could see it in HTMLTrackElement.idl:
"attribute [Reflect=default] boolean isDefault;"

http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLTrackElement.idl

> I could see it in HTMLTrackElement.idl:
> "attribute [Reflect=default] boolean isDefault;"

In JS, it will be track.isDefault instead of track.default.
We would like to have
attribute [Reflect] boolean default;

[Arun Patole]

(In reply to comment #2)
> > I could see it in HTMLTrackElement.idl:
> > "attribute [Reflect=default] boolean isDefault;"
> 
> In JS, it will be track.isDefault instead of track.default.
> We would like to have
> attribute [Reflect] boolean default;
ah, ok. There might be some reason for having isDefault and not 'default', Added Anna and Eric in cc.

[Eric Carlson]

(In reply to comment #3)
> (In reply to comment #2)
> > > I could see it in HTMLTrackElement.idl:
> > > "attribute [Reflect=default] boolean isDefault;"
> > 
> > In JS, it will be track.isDefault instead of track.default.
> > We would like to have
> > attribute [Reflect] boolean default;
> ah, ok. There might be some reason for having isDefault and not 'default', Added Anna and Eric in cc.

I *think* there was a compile problem on at least one port. The intention was to reflect the attribute as 'default', but that is clearly not happening and is a bug.

[Arun Patole]

Created attachment 130554 [details]
proposed patch

[Kentaro Hara]

Comment on attachment 130554 [details]
proposed patch

The change looks sane.

(In reply to comment #4)
> I *think* there was a compile problem on at least one port. The intention was to reflect the attribute as 'default', but that is clearly not happening and is a bug.

It seems that 'isDefault' was introduced in the initial patch of HTMLTrackElement.idl (https://bugs.webkit.org/attachment.cgi?id=89094&action=review).

[WebKit Review Bot]

Comment on attachment 130554 [details]
proposed patch

Clearing flags on attachment: 130554

Committed r110052: <http://trac.webkit.org/changeset/110052>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.