Bug 80116 - HTMLTrackElement.idl doesn't have default attribute.
Summary: HTMLTrackElement.idl doesn't have default attribute.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-01 23:55 PST by yosin
Modified: 2012-03-07 06:08 PST (History)
8 users (show)

See Also:


Attachments
proposed patch (3.06 KB, patch)
2012-03-06 23:32 PST, Arun Patole
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Arun Patole 2012-03-05 23:11:33 PST
(In reply to comment #0)
> See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#the-track-element

I could see it in HTMLTrackElement.idl:
"attribute [Reflect=default] boolean isDefault;"

http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLTrackElement.idl
Comment 2 yosin 2012-03-06 00:53:46 PST
> I could see it in HTMLTrackElement.idl:
> "attribute [Reflect=default] boolean isDefault;"

In JS, it will be track.isDefault instead of track.default.
We would like to have
attribute [Reflect] boolean default;
Comment 3 Arun Patole 2012-03-06 04:59:10 PST
(In reply to comment #2)
> > I could see it in HTMLTrackElement.idl:
> > "attribute [Reflect=default] boolean isDefault;"
> 
> In JS, it will be track.isDefault instead of track.default.
> We would like to have
> attribute [Reflect] boolean default;
ah, ok. There might be some reason for having isDefault and not 'default', Added Anna and Eric in cc.
Comment 4 Eric Carlson 2012-03-06 10:08:00 PST
(In reply to comment #3)
> (In reply to comment #2)
> > > I could see it in HTMLTrackElement.idl:
> > > "attribute [Reflect=default] boolean isDefault;"
> > 
> > In JS, it will be track.isDefault instead of track.default.
> > We would like to have
> > attribute [Reflect] boolean default;
> ah, ok. There might be some reason for having isDefault and not 'default', Added Anna and Eric in cc.

I *think* there was a compile problem on at least one port. The intention was to reflect the attribute as 'default', but that is clearly not happening and is a bug.
Comment 5 Arun Patole 2012-03-06 23:32:53 PST
Created attachment 130554 [details]
proposed patch
Comment 6 Kentaro Hara 2012-03-07 04:31:28 PST
Comment on attachment 130554 [details]
proposed patch

The change looks sane.

(In reply to comment #4)
> I *think* there was a compile problem on at least one port. The intention was to reflect the attribute as 'default', but that is clearly not happening and is a bug.

It seems that 'isDefault' was introduced in the initial patch of HTMLTrackElement.idl (https://bugs.webkit.org/attachment.cgi?id=89094&action=review).
Comment 7 WebKit Review Bot 2012-03-07 06:08:02 PST
Comment on attachment 130554 [details]
proposed patch

Clearing flags on attachment: 130554

Committed r110052: <http://trac.webkit.org/changeset/110052>
Comment 8 WebKit Review Bot 2012-03-07 06:08:07 PST
All reviewed patches have been landed.  Closing bug.