Bug 80108 - [Forms] HTMLFieldSetElement.idl doesn't have name attribute.
Summary: [Forms] HTMLFieldSetElement.idl doesn't have name attribute.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL: http://jsfiddle.net/2yYDD/
Keywords:
Depends on:
Blocks: HTML5Forms
  Show dependency tree / graph
 
Reported: 2012-03-01 23:40 PST by yosin
Modified: 2012-03-05 19:08 PST (History)
5 users (show)

See Also:

Attachments
Patch 1 (3.19 KB, patch)
2012-03-02 00:15 PST, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (4.77 KB, patch)
2012-03-02 02:00 PST, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (4.42 KB, patch)
2012-03-04 19:17 PST, yosin 		no flags Details | Formatted Diff | Diff
Patch 4 (4.42 KB, patch)
2012-03-05 01:28 PST, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-03-01 23:40:50 PST 
See http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#the-fieldset-element

Adding "name" attribute to IDL is easy, because class HTMLFieldSetElement has disabled method inherited from HTMLFormControlElement.
Comment 1 yosin 2012-03-02 00:15:13 PST 
Created attachment 129832 [details]
Patch 1
Comment 2 Kent Tamura 2012-03-02 00:29:51 PST 
Comment on attachment 129832 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=129832&action=review

> Source/WebCore/html/HTMLFieldSetElement.idl:24
> +        attribute DOMString name;

Please the specification carefully.
http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-fe-name

This IDL attribute reflects the name HTML attribute.
Comment 3 Kent Tamura 2012-03-02 00:30:26 PST 
(In reply to comment #2)
> Please the specification carefully.

Please read the ...
Comment 4 Kent Tamura 2012-03-02 00:47:20 PST 
(In reply to comment #2)
> > Source/WebCore/html/HTMLFieldSetElement.idl:24
> > +        attribute DOMString name;

> This IDL attribute reflects the name HTML attribute.

I should have added more words.  Sorry for the short comment.

If the specification says the attribute "reflects" a content attribute, we should add [Reflect] to the IDL.
Also, we need to add tests for the "reflect" behavior. e.g. fieldset.name = null, and check getAttribute('name') value.
Comment 5 yosin 2012-03-02 02:00:07 PST 
Created attachment 129849 [details]
Patch 2
Comment 6 Hajime Morrita 2012-03-04 18:15:37 PST 
Comment on attachment 129849 [details]
Patch 2

WebKit has its own testing harness. Please consider to use it.
See LayoutTests/fast/forms/ValidityState-customError.html for example.
Comment 7 yosin 2012-03-04 19:17:21 PST 
Created attachment 130043 [details]
Patch 3
Comment 8 Hajime Morrita 2012-03-05 01:02:23 PST 
Code looks good. Could you update the patch to match ToT?
Comment 9 yosin 2012-03-05 01:28:37 PST 
Created attachment 130078 [details]
Patch 4
Comment 10 WebKit Review Bot 2012-03-05 19:08:10 PST 
Comment on attachment 130078 [details]
Patch 4

Clearing flags on attachment: 130078

Committed r109836: <http://trac.webkit.org/changeset/109836>
Comment 11 WebKit Review Bot 2012-03-05 19:08:15 PST 
All reviewed patches have been landed.  Closing bug.