RESOLVED FIXED 80102
Make order of attribute/method in HTMLTrackElement.idl as same as specification 
https://bugs.webkit.org/show_bug.cgi?id=80102
Summary Make order of attribute/method in HTMLTrackElement.idl as same as specification
yosin
Reported 2012-03-01 22:26:28 PST
For ease of maintainability, attributes and methods declaration order should be as same as specification. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#the-track-element Similar work was done for input element: https://bugs.webkit.org/show_bug.cgi?id=79622
Attachments
Patch 1 (1.43 KB, patch)
2012-03-01 22:31 PST, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (1.41 KB, patch)
2012-08-02 22:19 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (1.42 KB, patch)
2012-08-02 22:22 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-03-01 22:31:15 PST
Created attachment 129822 [details] Patch 1
yosin
Comment 2 2012-03-01 22:33:03 PST
This is the last patch of series of Forms related IDL cleanup. (^_^)b
Kentaro Hara
Comment 3 2012-03-01 22:35:26 PST
Comment on attachment 129822 [details] Patch 1 r=me
Kent Tamura
Comment 4 2012-03-01 22:36:13 PST
Comment on attachment 129822 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=129822&action=review > Source/WebCore/ChangeLog:3 > + [Forms] Make order of attribute/method in HTMLTrackElement.idl as same as specification HTMLTrackElement is not related to Forms.
Kentaro Hara
Comment 5 2012-03-01 22:46:41 PST
(In reply to comment #4) > HTMLTrackElement is not related to Forms. Then I am neutral to the change. Generally speaking, ordering IDL attributes per the spec would be a good thing. On the other hand, we do not want to make a refactoring that does not have any benefit. I'd like to delegate the judgement to tkent (i.e. WONTFIX or r+).
Kent Tamura
Comment 6 2012-03-01 23:02:05 PST
(In reply to comment #5) > (In reply to comment #4) > > HTMLTrackElement is not related to Forms. > > Then I am neutral to the change. Generally speaking, ordering IDL attributes per the spec would be a good thing. On the other hand, we do not want to make a refactoring that does not have any benefit. I'd like to delegate the judgement to tkent (i.e. WONTFIX or r+). I'll be ok if we remove [Forms] from the summary.
yosin
Comment 7 2012-08-02 22:19:58 PDT
Created attachment 156260 [details] Patch 2
yosin
Comment 8 2012-08-02 22:22:09 PDT
Created attachment 156261 [details] Patch 3
yosin
Comment 9 2012-08-02 22:22:58 PDT
Comment on attachment 156261 [details] Patch 3 Could you review this patch? Thanks in advance. = Changes since the last review = * Remove "[Forms]" from bug summary and update ChangeLog
Kentaro Hara
Comment 10 2012-08-02 22:24:08 PDT
Comment on attachment 156261 [details] Patch 3 Looks OK.
yosin
Comment 11 2012-08-02 22:26:26 PDT
Comment on attachment 156261 [details] Patch 3 Clearing flags on attachment: 156261 Committed r124562: <http://trac.webkit.org/changeset/124562>
yosin
Comment 12 2012-08-02 22:26:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.