Bug 80102 - Make order of attribute/method in HTMLTrackElement.idl as same as specification
Summary: Make order of attribute/method in HTMLTrackElement.idl as same as specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-01 22:26 PST by yosin
Modified: 2012-08-02 22:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch 1 (1.43 KB, patch)
2012-03-01 22:31 PST, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (1.41 KB, patch)
2012-08-02 22:19 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (1.42 KB, patch)
2012-08-02 22:22 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-03-01 22:26:28 PST 
For ease of maintainability, attributes and methods declaration order should be as same as specification.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#the-track-element

Similar work was done for input element:
https://bugs.webkit.org/show_bug.cgi?id=79622
Comment 1 yosin 2012-03-01 22:31:15 PST 
Created attachment 129822 [details]
Patch 1
Comment 2 yosin 2012-03-01 22:33:03 PST 
This is the last patch of series of Forms related IDL cleanup. (^_^)b
Comment 3 Kentaro Hara 2012-03-01 22:35:26 PST 
Comment on attachment 129822 [details]
Patch 1

r=me
Comment 4 Kent Tamura 2012-03-01 22:36:13 PST 
Comment on attachment 129822 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=129822&action=review

> Source/WebCore/ChangeLog:3
> +        [Forms] Make order of attribute/method in HTMLTrackElement.idl as same as specification

HTMLTrackElement is not related to Forms.
Comment 5 Kentaro Hara 2012-03-01 22:46:41 PST 
(In reply to comment #4)
> HTMLTrackElement is not related to Forms.

Then I am neutral to the change. Generally speaking, ordering IDL attributes per the spec would be a good thing. On the other hand, we do not want to make a refactoring that does not have any benefit. I'd like to delegate the judgement to tkent (i.e. WONTFIX or r+).
Comment 6 Kent Tamura 2012-03-01 23:02:05 PST 
(In reply to comment #5)
> (In reply to comment #4)
> > HTMLTrackElement is not related to Forms.
> 
> Then I am neutral to the change. Generally speaking, ordering IDL attributes per the spec would be a good thing. On the other hand, we do not want to make a refactoring that does not have any benefit. I'd like to delegate the judgement to tkent (i.e. WONTFIX or r+).

I'll be ok if we remove [Forms] from the summary.
Comment 7 yosin 2012-08-02 22:19:58 PDT 
Created attachment 156260 [details]
Patch 2
Comment 8 yosin 2012-08-02 22:22:09 PDT 
Created attachment 156261 [details]
Patch 3
Comment 9 yosin 2012-08-02 22:22:58 PDT 
Comment on attachment 156261 [details]
Patch 3

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Remove "[Forms]" from bug summary and update ChangeLog
Comment 10 Kentaro Hara 2012-08-02 22:24:08 PDT 
Comment on attachment 156261 [details]
Patch 3

Looks OK.
Comment 11 yosin 2012-08-02 22:26:26 PDT 
Comment on attachment 156261 [details]
Patch 3

Clearing flags on attachment: 156261

Committed r124562: <http://trac.webkit.org/changeset/124562>
Comment 12 yosin 2012-08-02 22:26:32 PDT 
All reviewed patches have been landed.  Closing bug.