Bug 80101 - [Forms] Make order of attribute/method in HTMLTextAreaElement.idl as same as specification
Summary: [Forms] Make order of attribute/method in HTMLTextAreaElement.idl as same as ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-01 22:20 PST by yosin
Modified: 2012-03-02 05:32 PST (History)
5 users (show)

See Also:


Attachments
Patch 1 (3.30 KB, patch)
2012-03-01 22:24 PST, yosin
no flags Details | Formatted Diff | Diff
Patch 2 (3.25 KB, patch)
2012-03-01 23:17 PST, yosin
no flags Details | Formatted Diff | Diff
Patch 3 (3.45 KB, patch)
2012-03-02 00:18 PST, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-03-01 22:20:22 PST
For ease of maintainability, attributes and methods declaration order should be as same as specification.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element

Similar work was done for input element:
https://bugs.webkit.org/show_bug.cgi?id=79622
Comment 1 yosin 2012-03-01 22:24:29 PST
Created attachment 129818 [details]
Patch 1
Comment 2 Kentaro Hara 2012-03-01 22:29:56 PST
Comment on attachment 129818 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=129818&action=review

> Source/WebCore/html/HTMLTextAreaElement.idl:61
> +        // WinIE & FireFox extension:

I am afraid this comment would be mis-placed by this change. Please be careful not to move comments randomly.
Comment 3 yosin 2012-03-01 22:39:30 PST
Attribute "labels" are now in specification. It is better to remove this obsolete comment not to make people confusing.
Comment 4 Kentaro Hara 2012-03-01 22:42:55 PST
(In reply to comment #3)
> Attribute "labels" are now in specification. It is better to remove this obsolete comment not to make people confusing.

I am confused. The comment "// WinIE & FireFox extension:" had been written on selectionStart, selectionEnd, selectionDirection, setSelectionRange() and setSelectionRange(), right?
Comment 5 yosin 2012-03-01 22:51:36 PST
Oops, sorry for confusion.

Yes, comment "WinIE & FireFox extension" is above the "selectionStart" attribute, but I'm not sure this comments applied all of them.

Anyway, all of them after comments, selectionStart, selectionEnd, selectionDirection and setSelectionRange are now in standard.

IF this comment could be in line by line, e.g.
  attribute unsigned long selectionStart; // FF/IE extension
  attribute unsigned long selectionEnd; // FF/IE extension

easier to understand.
Comment 6 Kentaro Hara 2012-03-01 22:54:57 PST
Comment on attachment 129818 [details]
Patch 1

Makes sense!
Comment 7 Kent Tamura 2012-03-01 22:59:06 PST
Comment on attachment 129818 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=129818&action=review

> Source/WebCore/html/HTMLTextAreaElement.idl:64
> +        // WinIE & FireFox extension:
>  #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
>          void setSelectionRange(in long start, in long end);
>  #else

setSelectionRange() isn't WinIE/FireFox extension, and should be below selectionDirection.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element
Comment 8 yosin 2012-03-01 23:17:43 PST
Created attachment 129827 [details]
Patch 2
Comment 9 yosin 2012-03-01 23:18:50 PST
Thanks tkent@ good catch!
I remove "// WinIE & FireFox extension:"
Comment 10 Kent Tamura 2012-03-01 23:41:42 PST
Comment on attachment 129827 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=129827&action=review

> Source/WebCore/html/HTMLTextAreaElement.idl:55
>          attribute DOMString selectionDirection;
> +

setSelectionRange should be here.
Comment 11 yosin 2012-03-02 00:18:37 PST
Created attachment 129834 [details]
Patch 3
Comment 12 Kent Tamura 2012-03-02 01:02:20 PST
Comment on attachment 129834 [details]
Patch 3

ok
Comment 13 WebKit Review Bot 2012-03-02 05:31:55 PST
Comment on attachment 129834 [details]
Patch 3

Clearing flags on attachment: 129834

Committed r109565: <http://trac.webkit.org/changeset/109565>
Comment 14 WebKit Review Bot 2012-03-02 05:32:02 PST
All reviewed patches have been landed.  Closing bug.