Bug 80101 – [Forms] Make order of attribute/method in HTMLTextAreaElement.idl as same as specification

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

For ease of maintainability, attributes and methods declaration order should be as same as specification.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element

Similar work was done for input element:
https://bugs.webkit.org/show_bug.cgi?id=79622

Created attachment 129818 [details]
Patch 1

[Kentaro Hara]

Comment on attachment 129818 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=129818&action=review

> Source/WebCore/html/HTMLTextAreaElement.idl:61
> +        // WinIE & FireFox extension:

I am afraid this comment would be mis-placed by this change. Please be careful not to move comments randomly.

Attribute "labels" are now in specification. It is better to remove this obsolete comment not to make people confusing.

[Kentaro Hara]

(In reply to comment #3)
> Attribute "labels" are now in specification. It is better to remove this obsolete comment not to make people confusing.

I am confused. The comment "// WinIE & FireFox extension:" had been written on selectionStart, selectionEnd, selectionDirection, setSelectionRange() and setSelectionRange(), right?

Oops, sorry for confusion.

Yes, comment "WinIE & FireFox extension" is above the "selectionStart" attribute, but I'm not sure this comments applied all of them.

Anyway, all of them after comments, selectionStart, selectionEnd, selectionDirection and setSelectionRange are now in standard.

IF this comment could be in line by line, e.g.
  attribute unsigned long selectionStart; // FF/IE extension
  attribute unsigned long selectionEnd; // FF/IE extension

easier to understand.

[Kentaro Hara]

Comment on attachment 129818 [details]
Patch 1

Makes sense!

[Kent Tamura]

Comment on attachment 129818 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=129818&action=review

> Source/WebCore/html/HTMLTextAreaElement.idl:64
> +        // WinIE & FireFox extension:
>  #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
>          void setSelectionRange(in long start, in long end);
>  #else

setSelectionRange() isn't WinIE/FireFox extension, and should be below selectionDirection.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element

Created attachment 129827 [details]
Patch 2

Thanks tkent@ good catch!
I remove "// WinIE & FireFox extension:"

[Kent Tamura]

Comment on attachment 129827 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=129827&action=review

> Source/WebCore/html/HTMLTextAreaElement.idl:55
>          attribute DOMString selectionDirection;
> +

setSelectionRange should be here.

Created attachment 129834 [details]
Patch 3

[Kent Tamura]

Comment on attachment 129834 [details]
Patch 3

ok

[WebKit Review Bot]

Comment on attachment 129834 [details]
Patch 3

Clearing flags on attachment: 129834

Committed r109565: <http://trac.webkit.org/changeset/109565>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.