Bug 80089 – [Chromium] WebOptionElement should inherit WebElement instead of WebFormControlElement

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

According to specification, WebOptionElement isn't form associated control(FormControlElement is derived from FormAssociateElement) . To avoid having extra functionality and removing extra dependency, WebOptionElement should derive from WebElement rather than WebFormControlElement.

Created attachment 129804 [details]
Patch 1

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Darin Fisher (:fishd, Google)]

Comment on attachment 129804 [details]
Patch 1

Why?  HTMLOptionElement seems to inherit from HTMLFormControlElement, so it seems like the WebKit API should reflect that.

[Kent Tamura]

(In reply to comment #3)
> (From update of attachment 129804 [details])
> Why?  HTMLOptionElement seems to inherit from HTMLFormControlElement, so it seems like the WebKit API should reflect that.

HTMLOptionElement shouldn't inherit from HTMLFormControlElement. The current implementation of HTMLOptionElement wastes memory and time, and we have an actual performance bug reported by a user.  yosin is going to change it.  See Bug 79764.

[Darin Fisher (:fishd, Google)]

Comment on attachment 129804 [details]
Patch 1

OK!

[WebKit Review Bot]

Comment on attachment 129804 [details]
Patch 1

Clearing flags on attachment: 129804

Committed r109827: <http://trac.webkit.org/changeset/109827>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.