Bug 80082 - DOM tests take too long to run
Summary: DOM tests take too long to run
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-01 19:19 PST by Ryosuke Niwa
Modified: 2012-03-02 14:39 PST (History)
4 users (show)

See Also:


Attachments
Reduce benchmark.timeToRun from 500ms to 100ms (1.88 KB, patch)
2012-03-01 19:25 PST, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-01 19:19:00 PST
It seems like we can lower benchmark.timeToRun from 500 to 100 and still get a pretty decent number.
Comment 1 Ryosuke Niwa 2012-03-01 19:22:23 PST
e.g. we spend 121s in DOM/CreateNodes now:

Running DOM/CreateNodes.html (5 of 44)
RESULT DOM: CreateNodes= 377.584043095 ms
median= 377.545919724 ms, stdev= 1.48541786367 ms, min= 373.933014354 ms, max= 381.514733804 ms
Finished: 121.340621 s

By reducing the value, we only spend 30s:

Running DOM/CreateNodes.html (3 of 10)
RESULT DOM: CreateNodes= 376.635416667 ms
median= 376.0625 ms, stdev= 2.55494737253 ms, min= 373.0 ms, max= 381.458333333 ms
Finished: 29.826671 s
Comment 2 Ryosuke Niwa 2012-03-01 19:25:20 PST
Created attachment 129793 [details]
Reduce benchmark.timeToRun from 500ms to 100ms
Comment 3 Erik Arvidsson 2012-03-01 19:54:07 PST
Comment on attachment 129793 [details]
Reduce benchmark.timeToRun from 500ms to 100ms

View in context: https://bugs.webkit.org/attachment.cgi?id=129793&action=review

I'm not yet a reviewer but this looks good to me.

> PerformanceTests/DOM/resources/dom-perf.js:271
> +  }

this indentation still looks wrong.
Comment 4 Ryosuke Niwa 2012-03-01 23:40:47 PST
Comment on attachment 129793 [details]
Reduce benchmark.timeToRun from 500ms to 100ms

View in context: https://bugs.webkit.org/attachment.cgi?id=129793&action=review

>> PerformanceTests/DOM/resources/dom-perf.js:271
>> +  }
> 
> this indentation still looks wrong.

Oops, yeah this isn't right :(
Comment 5 Eric Seidel (no email) 2012-03-02 14:21:00 PST
Comment on attachment 129793 [details]
Reduce benchmark.timeToRun from 500ms to 100ms

LGTM.  You should consider adidng a comment next to the value about how/why 100ms was chosen.  If someone had comemnted next to teh 500ms this review would have been even easier. :)
Comment 6 Ryosuke Niwa 2012-03-02 14:26:02 PST
Thanks for the review.

(In reply to comment #5)
> (From update of attachment 129793 [details])
> LGTM.  You should consider adidng a comment next to the value about how/why 100ms was chosen.  If someone had comemnted next to teh 500ms this review would have been even easier. :)

Done.
Comment 7 Ryosuke Niwa 2012-03-02 14:39:57 PST
Landed in r109615.