WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WORKSFORME
80076
Make V8CSSStyleDeclaration work directly with CSS Property ID
https://bugs.webkit.org/show_bug.cgi?id=80076
Summary
Make V8CSSStyleDeclaration work directly with CSS Property ID
Ryosuke Niwa
Reported
2012-03-01 17:47:18 PST
http://trac.webkit.org/changeset/108257
improved DOM/Accessors.html's score by 45%. We should do the same optimization.
Attachments
Add attachment
proposed patch, testcase, etc.
Erik Arvidsson
Comment 1
2012-03-02 12:24:15 PST
We already do this optimization. cssPropertyInfo caches the lookup from the string to the property ID and whether the property has a pos or pixel prefix.
Kentaro Hara
Comment 2
2012-03-04 21:10:30 PST
(In reply to
comment #1
)
> We already do this optimization. > > cssPropertyInfo caches the lookup from the string to the property ID and whether the property has a pos or pixel prefix.
Thanks, arv. I confirmed it. Also I confirmed that the reason why V8's DOM/Accessors.html is still much slower than JSC's DOM/Accessors.html is due to the slowness of V8 DOM bindings. (I am investigating the issue in
https://docs.google.com/a/google.com/spreadsheet/ccc?key=0AlobCOyvTnPKdDhqQlpybE11Ui1fbTRHNFd2ZHh4bEE&ndplr=1#gid=0
)
Kentaro Hara
Comment 3
2012-03-05 01:55:24 PST
Although I played around some optimization, I couldn't optimize V8CSSStyleDeclaration as far as I modify V8CSSStyleDeclarationCustom.cpp. As a side effect of the investigation, I might be able to optimize JSCSSStyleDeclarationCustom.cpp:-)
bug 80250
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug