Bug 80071 – Move WebCore/storage/IDB* files into WebCore/Modules/indexeddb

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Move WebCore/storage/IDB* files into WebCore/Modules/indexeddb

[Adam Barth]

Created attachment 129775 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 129775 [details]
Patch

Attachment 129775 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11769657

[Adam Barth]

Created attachment 129781 [details]
Patch

[Build Bot]

Comment on attachment 129775 [details]
Patch

Attachment 129775 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11751623

[WebKit Commit Bot]

Attachment 129781 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/indexeddb/IDBObjectStore.h:74:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStore.h:47:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStore.h:62:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStore.h:76:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h:51:  The parameter name "task" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:514:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:1000:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBCursorBackendInterface.h:47:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBCursorBackendInterface.h:62:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:285:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:69:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:79:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:92:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:98:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h:54:  The parameter name "task" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:33:  "EventQueue.h" already included at Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:31  [build/include] [4]
Total errors found: 17 in 94 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 129781 [details]
Patch

Attachment 129781 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11751645

[Gyuyoung Kim]

Comment on attachment 129781 [details]
Patch

Attachment 129781 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11776708

[Adam Barth]

Created attachment 129784 [details]
Patch

[Collabora GTK+ EWS bot]

Comment on attachment 129784 [details]
Patch

Attachment 129784 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11757703

[Adam Barth]

Created attachment 129787 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 129787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129787&action=review

I assume you're just moving files and changing build systems?

> Source/WebCore/ChangeLog:15


You might consider running s/Copied/Moved/

> Source/WebCore/ChangeLog:105
> +        * storage/IDBAny.cpp: Removed.
> +        * storage/IDBAny.h: Removed.
> +        * storage/IDBAny.idl: Removed.

These double-entries are lame.

[Eric Seidel (no email)]

The EWSes are the real reviewers of patches like this. :p

[Adam Barth]

> I assume you're just moving files and changing build systems?

Correct.

> You might consider running s/Copied/Moved/

Will do.

[WebKit Review Bot]

Attachment 129787 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/indexeddb/IDBObjectStore.h:74:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStore.h:47:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStore.h:62:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStore.h:76:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h:51:  The parameter name "task" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:514:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:1000:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBCursorBackendInterface.h:47:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBCursorBackendInterface.h:62:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:285:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:69:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:79:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:92:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:98:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h:54:  The parameter name "task" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:33:  "EventQueue.h" already included at Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:31  [build/include] [4]
Total errors found: 17 in 97 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kentaro Hara]

Comment on attachment 129787 [details]
Patch

r=me. I guess you need to commit the patch manually to avoid style check errors. Please commit it after confirming the green face of the cr-linux ews.

[Adam Barth]

I've confirmed cr-mac and apple-mac locally.

[Adam Barth]

Committed r109493: <http://trac.webkit.org/changeset/109493>