Bug 80065 – Editor's default paragraph separator is not reset when a frame's document is changed

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Pablo Flouret]

If a page somehow changes the value of Editor::m_shouldStyleWithCSS, Editor::m_defaultParagraphSeparator, etc. those values persist after the page is navigated away/refreshed/etc.

[Alexey Proskuryakov]

Could you please prove a test case?

[Pablo Flouret]

(In reply to comment #1)
> Could you please prove a test case?

This came up from https://bugs.webkit.org/show_bug.cgi?id=59961#c20 but i see now that i missed Editor::clear(), so i'll just reset the default paragraph separator there.

Patch coming up.

[Pablo Flouret]

Created attachment 129983 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 129983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129983&action=review

> LayoutTests/editing/resources/reset-default-values-helper.html:6
> +        location.href = location.href + (location.search == "" ? "?" : "&") + "ohhai";

I don't think adding query string works on all ports. You should probably add one more file. By the way, this file should be in editing/execCommand/resources instead.

[Pablo Flouret]

Created attachment 129984 [details]
Patch

[WebKit Review Bot]

Comment on attachment 129984 [details]
Patch

Rejecting attachment 129984 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
_by_email
    return self._reviewer_only(self.account_by_email(email))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 632, in account_by_email
    return self._email_to_account_map().get(email.lower()) if email else None
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 525, in _email_to_account_map
    assert(email not in self._accounts_by_email)  # We should never have duplicate emails.
AssertionError

Full output: http://queues.webkit.org/results/11795262

[WebKit Review Bot]

Comment on attachment 129984 [details]
Patch

Clearing flags on attachment: 129984

Committed r109653: <http://trac.webkit.org/changeset/109653>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.